Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libigl] Initial integration #5708

Merged
merged 2 commits into from
Jul 1, 2021
Merged

[libigl] Initial integration #5708

merged 2 commits into from
Jul 1, 2021

Conversation

AdamKorcz
Copy link
Collaborator

@AdamKorcz AdamKorcz commented May 4, 2021

Initial integration of libigl.

Companies that use libigl include:

  • Adobe
  • Electronic Arts, Inc
  • Epic Games
  • Microsoft Research
  • Ubisoft

An list of selected users can be found here: https://libigl.github.io/#projectsuniversities-using-libigl


@jdumas Are you interested in integrating Libigl into OSS-fuzz?
All we need is an email address for bug reports to complete this PR.
If this gets merged, then libigl/libigl#1802 can be closed.

@AdamKorcz
Copy link
Collaborator Author

@jdumas Kind ping.

@jdumas
Copy link

jdumas commented Jun 28, 2021

Oh sorry I forgot to answer. Please use github [at] jdumas.org for the email address. Thanks!

@AdamKorcz
Copy link
Collaborator Author

@inferno-chromium @oliverchang @jonathanmetzman @asraa @DavidKorczynski Libigl is ready for review

@AdamKorcz AdamKorcz marked this pull request as ready for review July 1, 2021 22:27
@oliverchang oliverchang merged commit 201e928 into google:master Jul 1, 2021
@jdumas
Copy link

jdumas commented Jul 2, 2021

@AdamKorcz I have received several reports from OSS fuzz, but I cannot click on the links to get access to the detailed reports. It is expecting me to login with a gmail account (different from the email I provided to receive the bug reports), but when I try to do so it tells me that You (email=xxx) are not authorized to access this page!. Is there any way around that?

@AdamKorcz
Copy link
Collaborator Author

@jdumas Only the email addresses in project.yaml have access. Are you logging in with github [at] jdumas.org?

@jdumas
Copy link

jdumas commented Jul 2, 2021

I don't see any option to login with a non-gmail account.

@jdumas
Copy link

jdumas commented Jul 2, 2021

Screen Shot 2021-07-02 at 9 06 22 AM

@AdamKorcz
Copy link
Collaborator Author

AdamKorcz commented Jul 2, 2021

It does not have to be a gmail account, but some email extensions are not approved to access the bug reports.

If you cannot log in with the current email address it would be because jdumas.org is not recognized.

See Davids comment below.

I can add another email address to project.yaml for you if you'd like.

@DavidKorczynski
Copy link
Collaborator

DavidKorczynski commented Jul 2, 2021

@AdamKorcz @jdumas The account need not be a gmail account but the emails in project.yaml must be affiliated with a google account.

@jdumas I assume your @jdumas.org email is not affiliated with any google account? To solve this, either link your email to a google account (https://support.google.com/accounts/answer/27441?hl=en) or we should just put in a gmail.

@jdumas
Copy link

jdumas commented Jul 2, 2021

Do you mean I should add this as an alternate email to my gmail account?

Screen Shot 2021-07-02 at 9 18 33 AM

@DavidKorczynski
Copy link
Collaborator

You could either link github@jdumas.org to a Google account or we could put your gmail account in the project.yaml - either works.

@jdumas
Copy link

jdumas commented Jul 2, 2021

Sorry I'm still not super clear on how to "link" an email to a google account. The link you provided above explains how to create a new account, not how to link an email to an existing account. Do you mean to enter the email as an alternate email as described in the screenshot I posted above?

@DavidKorczynski
Copy link
Collaborator

Sorry I'm still not super clear on how to "link" an email to a google account. The link you provided above explains how to create a new account, not how to link an email to an existing account. Do you mean to enter the email as an alternate email as described in the screenshot I posted above?

Ah apologies, I also misunderstood. Yes that should work!

@jdumas
Copy link

jdumas commented Jul 2, 2021

Yeah I'm still getting a permission denied.

@DavidKorczynski
Copy link
Collaborator

Ah sorry! Many apologies here. It looks like there are some limitations for alternate emails (https://google.github.io/oss-fuzz/getting-started/accepting-new-projects/): If you use an alternate email address linked to a Google Account, you’ll only get access to filed bugs in the issue tracker, not to the ClusterFuzz dashboard. This is due to appengine API limitations.

Sorry for the confusion. Would it be possible to use a Google account without an alternate email?

@jdumas
Copy link

jdumas commented Jul 2, 2021

I'd rather not be forced to use a gmail address due to stupid arbitrary limitations.

@DavidKorczynski
Copy link
Collaborator

it doesn't force you to use a gmail. I use david@adalogics and many others use non-gmail addresses. The alternative aspect refers to an email that is not the primary email of a Google account. If you have a Google account where you primary email is your github@jdumas, then that should work.

@jdumas
Copy link

jdumas commented Jul 2, 2021

Fine I guess I'll be create a new account specifically for this purpose then... Still pretty annoying tbh.

@DavidKorczynski
Copy link
Collaborator

Thanks for the flexibility - and yeah it would be great to have additional authentication features added.

Cross-referencing:
#1915
#2261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants