unicode-rs: initial integration. #5413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
approved these changes
Apr 1, 2021
There was a problem hiding this comment.
Looks good, please use manishsmail@gmail.com.
Happy to upstream fuzzers as well; whatever works for y'all!
projects/unicode-rs/unicode-segmentation-fuzz/fuzz_targets/fuzz_target_1.rs
Outdated
Show resolved
Hide resolved
|
@inferno-chromium @oliverchang @jonathanmetzman calling on the current sheriff this one is good to go. |
inferno-chromium
approved these changes
May 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performs an umbrella integration for Unicode-related repositories:
Unicode normalisation uses unsafe https://github.com/unicode-rs/unicode-normalization/search?q=unsafe code whereas unicode-segmentation does not.
@Manishearth I have set up continuous fuzzing of unicode-rs repos. The benefits are that the fuzzer will be run on a regular basis. Is this something you would be happy to have set up? If so, the only thing needed from your end is an email that will receive the bugs reports - notice this email should be attached to a Google account for you to see the reports. I can also move the fuzzers for
unicode-segmentationto the upstream repo.