-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test project for the Bazel fuzzing rules. #4936
Add test project for the Bazel fuzzing rules. #4936
Conversation
Usually people just specify it in dockerfile clone command, we don't support different project version with params. can you please tell the usecase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor changes.
We discussed with Oliver that this test project could be used as a regression test in a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL.
…, to better convey intent.
29ae872
to
c284ed9
Compare
# | ||
################################################################################ | ||
|
||
declare -r QUERY=' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is test project, it is good to add comments on each step in this file. Can you do this in next PR. Also, need to remember to add docs on subsection of https://google.github.io/oss-fuzz/getting-started/new-project-guide/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is test project, it is good to add comments on each step in this file. Can you do this in next PR.
I've just seen this. Let me do this in #5039.
Also, need to remember to add docs on subsection of https://google.github.io/oss-fuzz/getting-started/new-project-guide/
Good point, let me do this in a subsequent PR. I'm planning to overhaul documentation in the rules_fuzzing
library, too.
This PR is in reference to bazel-contrib/rules_fuzzing#105. This is a disabled OSS-Fuzz project that builds all the fuzz target examples in bazelbuild/rules_fuzzing and generates the OSS-Fuzz packaging for them.
Question to reviewers: Is there a way this project can be used to test new changes on a branch in bazelbuild/rules_fuzzing? Right now the Dockerfile hard-codes the master branch when it clones the repo. Can this be parameterized somehow? Has anyone done this before?