-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Dovecot project #3502
Added Dovecot project #3502
Conversation
…1) targets for readelf (with sample ELF file) and cxxfilt and (3) added my email to the project yaml. Fixed travis. Removed whitespace and fixed commit email for google cla Fixed travis. Removed whitespace and fixed commit email for google cla
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable overall. Could you re-request review once the fuzzers have been landed upstream so that travis passes? I'd also recommend cleaning up some of the commented-out code or bits included for debugging before then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs merged work from upstream repository
projects/dovecot/build.sh
Outdated
|
||
|
||
# fuzz-imap-utf7 | ||
clang $CFLAGS -DHAVE_CONFIG_H -I. -I../.. -I../../src/lib -I../../src/lib-test -I../../src/lib-charset -I../../src/lib-mail -std=gnu99 -fstack-protector-strong -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wpointer-arith -Wchar-subscripts -Wformat=2 -Wbad-function-cast -Wno-duplicate-decl-specifier -Wstrict-aliasing=2 -MT test-imap-utf7.o -MD -MP -c -o fuzz-imap-utf7.o fuzz-imap-utf7.c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fuzz targets should be built by make
cf dovecot/core#117
This way, we do not have to modify oss-fuzz each time a new fuzz target is added to dovecot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good - I will update once @sirainen finalises his thoughts on how it will be added in Dovecot!
…integrated the build process into the actual project.
Travis tests have failedHey @DavidKorczynski, 4th Build./infra/travis/travis_build.py
TravisBuddy Request Identifier: 70984ac0-6e96-11ea-bef5-ab2a7fe30e4a |
Travis tests have failedHey @DavidKorczynski, 3rd Build./infra/travis/travis_build.py
TravisBuddy Request Identifier: 5076a010-6e97-11ea-bef5-ab2a7fe30e4a |
Travis tests have failedHey @DavidKorczynski, 3rd Build./infra/travis/travis_build.py
TravisBuddy Request Identifier: 2e50fc50-6eca-11ea-bef5-ab2a7fe30e4a |
Looks like build.sh should begin with |
Hey @mbarbella-chromium ! Could you please review again? In the end the maintainers of Dovecot were very enthusiastic and did a great job integrating it nicely into the Dovecot building process (dovecot/core#116 and https://github.com/dovecot/core/pull/117/files). This should be a good setup for future fuzzing of Dovecot too! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hey! I found dovecot was not #402 marked as solved - @DavidKorczynski maybe worth saying it there :))) |
yay, marked as Done! Thanks a lot! |
I added the Dovecot project with three initial fuzzers. Please follow the thread on Dovecots repo about progress: dovecot/core#116
By the looks of it they will provide an email soon that can get the bug reports, then I will update here. I made this pull request so we can follow progress both places.