[infra] use $SWITCH_UID if it is defined (fixes #30) #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW I'm not 100 happy with variable name. Suggestions are welcome. |
Dor1s
approved these changes
Dec 21, 2016
| @@ -148,6 +148,7 @@ def build_fuzzers(build_args): | |||
|
|
|||
| command = [ | |||
| 'docker', 'run', '--rm', '-i', | |||
| '-e', 'SWITCH_UID=' + os.getuid(), | |||
There was a problem hiding this comment.
Doesn't os.getuid() return an integer? If yes, let's do 'SWITCH_UID=%d' % os.getuid() + let's use format string on line 154 instead of concatenation.
inferno-chromium
requested changes
Dec 21, 2016
| @@ -41,6 +41,7 @@ Build configuration is performed through following environment variables: | |||
| | `$SANITIZER ("address")` | Specifies sanitizer configuration to use. `address` or `undefined`. | |||
| | `$SANITIZER_FLAGS` | Specify compiler sanitizer flags directly. Overrides `$SANITIZER`. | |||
| | `$COVERAGE_FLAGS` | Specify compiler flags to use for fuzzer feedback coverage. | |||
| | `$SWITCH_UID` | User id to use while building fuzzers. | |||
There was a problem hiding this comment.
BUILD_UID is a better name i think.
| BUILD_CMD="bash -x $SRC/build.sh" | ||
| if [ -z "${SWITCH_UID+}" ]; then | ||
| adduser -u $SWITCH_UID --disabled-password --no-create-home --gecos '' ossfuzz | ||
| chown -R ossfuzz /src |
There was a problem hiding this comment.
Can we use $SRC.
| if [ -z "${SWITCH_UID+}" ]; then | ||
| adduser -u $SWITCH_UID --disabled-password --no-create-home --gecos '' ossfuzz | ||
| chown -R ossfuzz /src | ||
| chown ossfuzz /out |
There was a problem hiding this comment.
Can we use $OUT.
| bash -x $SRC/build.sh | ||
| BUILD_CMD="bash -x $SRC/build.sh" | ||
| if [ -z "${SWITCH_UID+}" ]; then | ||
| adduser -u $SWITCH_UID --disabled-password --no-create-home --gecos '' ossfuzz |
There was a problem hiding this comment.
nit: s/ossfuzz/build-user or something.
If #SWITCH_UID is defined, then compile script will create a user with a given UID and switch to it prior to calling project's build.sh.
mikea
commented
Dec 21, 2016
| @@ -41,6 +41,7 @@ Build configuration is performed through following environment variables: | |||
| | `$SANITIZER ("address")` | Specifies sanitizer configuration to use. `address` or `undefined`. | |||
| | `$SANITIZER_FLAGS` | Specify compiler sanitizer flags directly. Overrides `$SANITIZER`. | |||
| | `$COVERAGE_FLAGS` | Specify compiler flags to use for fuzzer feedback coverage. | |||
| | `$SWITCH_UID` | User id to use while building fuzzers. | |||
| bash -x $SRC/build.sh | ||
| BUILD_CMD="bash -x $SRC/build.sh" | ||
| if [ -z "${SWITCH_UID+}" ]; then | ||
| adduser -u $SWITCH_UID --disabled-password --no-create-home --gecos '' ossfuzz |
| BUILD_CMD="bash -x $SRC/build.sh" | ||
| if [ -z "${SWITCH_UID+}" ]; then | ||
| adduser -u $SWITCH_UID --disabled-password --no-create-home --gecos '' ossfuzz | ||
| chown -R ossfuzz /src |
| if [ -z "${SWITCH_UID+}" ]; then | ||
| adduser -u $SWITCH_UID --disabled-password --no-create-home --gecos '' ossfuzz | ||
| chown -R ossfuzz /src | ||
| chown ossfuzz /out |
| @@ -148,6 +148,7 @@ def build_fuzzers(build_args): | |||
|
|
|||
| command = [ | |||
| 'docker', 'run', '--rm', '-i', | |||
| '-e', 'SWITCH_UID=' + os.getuid(), | |||
|
LGTM |
DavidKorczynski
pushed a commit
that referenced
this pull request
Jul 9, 2024
Hi, I upgraded the oss-fuzz-gen project’s OpenAI SDK dependency from version 0.27.8 to version >=1.0.0, in line with OpenAI's official recommendations. This move is motivated by the significant enhancements introduced in version 1.0.0, which OpenAI details [here](openai/openai-python#742). Key improvements include: - A complete rewrite of the library for robustness and error resilience. - Introduction of explicit client instantiation, replacing the global default and offering more flexible SDK interaction. After upgrading to v1.16.2 (the latest available), I tested the integration with my API key and confirmed full functionality. This upgrade aligns oss-fuzz-gen with current best practices and ensures compatibility with future developments in AI technologies. Hope it helps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If #SWITCH_UID is defined, then compile script will create a user
with a given UID and switch to it prior to calling project's build.sh.