Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requests version 2.2.0 #1913

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Update requests version 2.2.0 #1913

merged 1 commit into from
Oct 30, 2018

Conversation

jonathanmetzman
Copy link
Contributor

No description provided.

@jonathanmetzman
Copy link
Contributor Author

Landing trivial change.
Change doesn't break build_fuzzers or build_image or coverage.

@jonathanmetzman jonathanmetzman merged commit 96fce46 into master Oct 30, 2018
@Dor1s
Copy link
Contributor

Dor1s commented Oct 30, 2018

Change doesn't break build_fuzzers or build_image or coverage.

I'm not sure if helper.py uses this. This is a dependency needed for GCB scripts (e.g. https://github.com/google/oss-fuzz/blob/master/infra/gcb/build_project.py).

Since you've already landed this, we can manually kick off some project build (I've just launched zlib) and see if it goes through.

@Dor1s
Copy link
Contributor

Dor1s commented Oct 30, 2018

Yeah, both regular build and coverage job finished successfully, thanks for the upgrade!

@oliverchang
Copy link
Collaborator

thanks! was there something that prompted this?

@jonathanmetzman
Copy link
Contributor Author

inferno-chromium added a commit that referenced this pull request Nov 3, 2018
inferno-chromium added a commit that referenced this pull request Nov 3, 2018
* Revert "Update requests version (#1913)"

This reverts commit 96fce46.
@Dor1s Dor1s deleted the requests branch February 1, 2019 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants