[poppler] Add poppler #1431
Merged
[poppler] Add poppler #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I don't think aacid@kde.org has an associated google account you can use tsdgeos@gmail.com i guess |
|
This is ready to merge. |
projects/poppler/pdf_fuzzer.options
Outdated
| @@ -0,0 +1 @@ | |||
| [libfuzzer] | |||
There was a problem hiding this comment.
This is not needed.
|
So i just realized the test code is wrong and is not checking for is_locked before trying to use the document which is basically a misuse of the API (that ends up in crashes if you do, but that's not a security issue, it's just people not using the library correctly) I guess i should just propose a fix? |
tmatth
pushed a commit
to tmatth/oss-fuzz
that referenced
this pull request
Oct 22, 2018
* [poppler] Add poppler * cleanup * remove empty options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #402.
👋 @tsdgeos This adds a fuzzer for poppler that will be continuously updated and run in the OSS-Fuzz infrastructure. Assuming you are okay with this, please confirm that
aacid@kde.orgis your email address and has a Google account associated with it (this account will be used to access restricted bugs filed by the fuzzers). Also, should anyone else have access to the bugs?