Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projects with MSAN disabled because of upgrade to Ubuntu 20.04 #6294

Open
jonathanmetzman opened this issue Aug 24, 2021 · 5 comments
Open

Comments

@jonathanmetzman
Copy link
Contributor

jonathanmetzman commented Aug 24, 2021

You are probably reading this issue because MSAN was disabled in your project during the upgrade to Ubuntu 20.04
Note that if your project was broken before the upgrade it is not included on this list.

Ubuntu 16.04 had prebuilt MSAN libraries, but Ubuntu 20.04 does not and we don’t expect this to change.
This allowed many projects to use MSAN easily, because when using MSAN all executed code must be instrumented with MSAN.
This means that to re-enable MSAN, your project can no longer link against the versions of these libraries provided by apt.
Instead your project must build these libraries from source and instrument them with MSAN using MSAN builds.
If you are able and willing to make this change, please submit the change as a pull request and comment here that you have fixed the issue, so we can track fixes.
Thank you!

LebedevRI added a commit to LebedevRI/oss-fuzz that referenced this issue Sep 4, 2021
I was not notified about that change, which i believe to be errneous.
The fuzzers built here do *not* link to *any* outside libraries.

Refs. google#6281
Refs. google#6294
LebedevRI added a commit to LebedevRI/oss-fuzz that referenced this issue Sep 4, 2021
I was not notified about that change, which i believe to be errneous.
The fuzzers built here do *not* link to *any* outside libraries.

Refs. google#6281
Refs. google#6294
inferno-chromium pushed a commit that referenced this issue Sep 4, 2021
I was not notified about that change, which i believe to be errneous.
The fuzzers built here do *not* link to *any* outside libraries.

Refs. #6281
Refs. #6294
@maflcko
Copy link
Contributor

maflcko commented Sep 10, 2021

It looks like the MSAN upgrade may fix some (presumed) false positives. One example: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34844 was only reproducible on OSS-Fuzz Xenial, but not OSS-Fuzz Focal or locally with MSAN/valgrind.

@jonathanmetzman
Copy link
Contributor Author

Yes I'm aware. I'm going to be fixing these later next week.

@dlemstra
Copy link
Contributor

Would it possible to add some information on how we can test if we could re-enable MSAN again @jonathanmetzman? The other issue mentions that some tests where done and I am wondering if it is possible to share some extra information?

@maflcko
Copy link
Contributor

maflcko commented Mar 27, 2023

I guess the best way forward now would be to just re-enable it and see if any issues arise, then either fix them or disable it again?

@jonathanmetzman
Copy link
Contributor Author

Yup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants