Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference to solve_wrapper in Solve method #3719

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

djsilcock
Copy link
Contributor

Calling solver.StopSearch() (as opposed to from within the solution callback) does not work:

solver=CPSolver()
def stopper():
    solver.StopSearch()
threading.Timer(30,stopper) #in real life would be some external event
solver.Solve()

because self.__solve_wrapper is never set in Solve method

@google-cla
Copy link

google-cla bot commented Mar 26, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lperron lperron merged commit a37ec3a into google:main Mar 28, 2023
@lperron
Copy link
Collaborator

lperron commented Mar 28, 2023

Thanks

@djsilcock djsilcock deleted the patch-1 branch March 28, 2023 22:08
@Mizux Mizux added this to the v9.12 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants