oboe: add Quirk for broken mono on S9 #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Samsung S9 does not support mono properly. It is actually stereo. So on that device, we open a stereo stream and then convert it to mono by extracting the first channel. Fixes #824
philburk
commented
Jun 12, 2020
This is used by the QuirksManager.
dturner
reviewed
Jun 16, 2020
| @@ -30,6 +30,7 @@ set (oboe_sources | |||
| src/flowgraph/ClipToRange.cpp | |||
| src/flowgraph/ManyToMultiConverter.cpp | |||
| src/flowgraph/MonoToMultiConverter.cpp | |||
| src/flowgraph/MultiToMonoConverter.cpp | |||
There was a problem hiding this comment.
Couldn't both MultiToMono and MonoToMulti be contained within single ChannelCountConverter which takes an arbitrary number of input and output channels?
There was a problem hiding this comment.
I added a ChannelCountConverter for the previous unsupported case, eg "2:3". But it looks a bit more complex and is slower than the Mono nodes. So I kept them as optimizations for the mono cases.
dturner
reviewed
Jun 16, 2020
dturner
reviewed
Jun 16, 2020
dturner
reviewed
Jun 16, 2020
src/common/QuirksManager.cpp
Outdated
| ) { | ||
| // Workaround for heap size regression in O. | ||
| // b/66967812 AudioRecord does not allow FAST track for stereo capture in O | ||
| childBuilder.setChannelCount(1); |
dturner
reviewed
Jun 16, 2020
dturner
reviewed
Jun 16, 2020
dturner
reviewed
Jun 17, 2020
| @@ -110,6 +110,9 @@ class QuirksManager { | |||
|
|
|||
| private: | |||
|
|
|||
| static constexpr int32_t kChannelCountMono = 1; | |||
There was a problem hiding this comment.
Rather than add these I think you can use the oboe::ChannelCount::* constants
dturner
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Samsung S9 does not support mono properly.
It is actually stereo. So on that device, we open a stereo
stream and then convert it to mono by extracting
the first channel.
Fixes #824