Start linear ramps at the initial volume set #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philburk
requested changes
Jun 28, 2021
src/flowgraph/RampLinear.cpp
Outdated
| @@ -32,6 +32,10 @@ void RampLinear::setLengthInFrames(int32_t frames) { | |||
|
|
|||
| void RampLinear::setTarget(float target) { | |||
| mTarget.store(target); | |||
| // If the ramp has not been used then start immediately at this level. | |||
| if (mLastCallCount < 0) { | |||
There was a problem hiding this comment.
Could check == kInitialCallCount
There was a problem hiding this comment.
Good idea! Addressed in the second commit!
philburk
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this ramp starts at 0 for the first ramp for no reason. Start this at the initial volume set.
This will help with clicking issues when pressing the volume up and down keys.
Tested via: Installed and ran updated tests via UnitTestRunner app