Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional code for OpenSL ES float format on API 21+ won't work #52

Closed
dturner opened this issue Feb 6, 2018 · 2 comments
Closed
Assignees

Comments

@dturner
Copy link
Collaborator

dturner commented Feb 6, 2018

This code (which I wrote) is intended to determine whether floating point format is available on this device based on the runtime API level:

https://github.com/google/oboe/blob/master/src/opensles/AudioOutputStreamOpenSLES.cpp#L112

However, __ANDROID_API__ is a preprocessor define so will give the compile time API level (usually API 16) so floating point won't be available on any device.

mnaganov@ has a solution in his pull request here: d35c572#diff-d0e527b6330d249f712b4e30bf3dde92R96

@philburk
Copy link
Collaborator

This Issue could benefit from this Feature: #56

@philburk
Copy link
Collaborator

philburk commented Mar 27, 2018

We can use the new query added in #64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants