Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OboeTester Data Paths test failing intermittently #2068

Closed
philburk opened this issue Jul 10, 2024 · 1 comment · Fixed by #2069
Closed

OboeTester Data Paths test failing intermittently #2068

philburk opened this issue Jul 10, 2024 · 1 comment · Fixed by #2069
Assignees
@philburk

Comments

@philburk
Copy link
Collaborator

This may be related to FullDuplex callbacks where the numOutputFrames does not match the numInputFrames.

The analyzer may not be handling that correctly. The input analyzer needs its own tracking sine wave and should not compare itself to the output sine wave. That may be the issue.
@philburk philburk self-assigned this Jul 10, 2024
philburk added a commit that referenced this issue Jul 11, 2024
@philburk
OboeTester: add sine wave oscillator as a reference for input
136d033 
This will prevent glitches caused by the number of input and
output frames being different in the full duplex callback.

Fixes #2068
@philburk
Copy link
Collaborator Author

We were using a separate sinewave for the GlitchActivity because we were actually tracking the input signal.

But we were not using it in the DataPaths Activity. So I moved support for having both an input and
and output sine wave into BaseSineAnalyzer. Now the SRC Data Path tests are all passing
when using the Google adapter.

@philburk philburk mentioned this issue Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philburk philburk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

OboeTester: add sine wave oscillator as a reference for input google/oboe
1 participant
@philburk