Cannot open recording stream on Motorola Moto G 2nd Gen

[dturner]

Steps to repro:

• Run the LiveEffect sample
• Hit Start

Expected outcome:

• Audio from the microphone is heard through the speaker or headphones

Actual outcome:

• No audio is heard from the speaker or headphones

The following logcat output shows that the recording stream fails to be created:

07-21 18:51:02.063 16034-16034/com.google.sample.oboe.liveeffect E/libOpenSLES: Cannot create AudioRecorder: data sink must be in PCM format
07-21 18:51:02.063 16034-16034/com.google.sample.oboe.liveeffect E/libOpenSLES: Cannot create AudioRecorder: invalid source or sink
07-21 18:51:02.063 16034-16034/com.google.sample.oboe.liveeffect W/libOpenSLES: Leaving Engine::CreateAudioRecorder (SL_RESULT_PARAMETER_INVALID)
07-21 18:51:02.063 16034-16034/com.google.sample.oboe.liveeffect E/OboeAudio: createAudioRecorder() result:SL_RESULT_PARAMETER_INVALID
07-21 18:51:02.063 16034-16034/com.google.sample.oboe.liveeffect E/AUDIO-APP: Failed to create recording stream. Error: ErrorInternal
07-21 18:51:02.063 16034-16034/com.google.sample.oboe.liveeffect E/AUDIO-APP: Failed to create recording (0x0) and/or playback (0xb8aef600) stream

[dturner]

It appears that the Moto G doesn't support floating point recording.

I verified this by commenting out this block.

[philburk]

What version was the Moto G running?

Is this a version issue or vendor implementation issue?
I would think that the FLOAT code in OpenSL ES would all be above the level of the HAL.

[dturner]

The Moto G was running API 21 LXB22.99-16.3.

The only reference I can find to that error message is here: https://android.googlesource.com/platform/frameworks/wilhelm/+/4597a74/libopensles/android_AudioRecorder.cpp#61

So it could be a version issue, although I was sure that API 21 had float support for recording streams. Maybe that was introduced later?

[dturner]

I just tested a Samsung Galaxy S4 running API 21 and ran into the same issue. Looks like it is a version issue.

[dturner]

Once we figure out what is the expected behaviour we should definitely add a test for this.

[dturner]

It appears that float playback capability was added to Lollipop but float record capability was only added in Marshmallow.

Verified by running repro steps on emulators:

API 21 - error message
API 22 - error message
API 23 - no error
API 24 - no error

[vbarthel-fr]

Here is an attempt at addressing this issue: #205

As mentioned in the PR, I don't have the knowledge required to fully understand the consequences of those changes. See the description of the PR for more details :)

[vbarthel-fr]

My bad, there is already an opened PR addressing this issue: #194

Sorry for all that :/