OboeTester: fix assert in FormatConverterBox (#2012)

Fixed calculation of required buffer size for input format conversion. Fixes #2011
google · Apr 30, 2024 · b8f12a8 · b8f12a8
1 parent d103042
commit b8f12a8
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/apps/OboeTester/app/src/main/cpp/FullDuplexStreamWithConversion.cpp b/apps/OboeTester/app/src/main/cpp/FullDuplexStreamWithConversion.cpp
@@ -19,12 +19,13 @@
 
 oboe::Result FullDuplexStreamWithConversion::start() {
     // Determine maximum size that could possibly be called.
-    int32_t bufferSize = getOutputStream()->getBufferCapacityInFrames()
-                         * getOutputStream()->getChannelCount();
-    mInputConverter = std::make_unique<FormatConverterBox>(bufferSize,
+    int32_t maxFrames = getOutputStream()->getBufferCapacityInFrames();
+    int32_t inputBufferSize = maxFrames * getInputStream()->getChannelCount();
+    int32_t outputBufferSize = maxFrames * getOutputStream()->getChannelCount();
+    mInputConverter = std::make_unique<FormatConverterBox>(inputBufferSize,
                                                            getInputStream()->getFormat(),
                                                            oboe::AudioFormat::Float);
-    mOutputConverter = std::make_unique<FormatConverterBox>(bufferSize,
+    mOutputConverter = std::make_unique<FormatConverterBox>(outputBufferSize,
                                                             oboe::AudioFormat::Float,
                                                             getOutputStream()->getFormat());
     return FullDuplexStream::start();