Skip to content

Commit

Permalink
Add unit tests for testing getFramesWritten returns correctly. (#1276)
Browse files Browse the repository at this point in the history
* Add unit tests for testing frames processed.

Add unit tests to that open input/output stream and process data for a
while and then verify the returned values from getFramesWritten and
getFramesRead are correct.

Fixes #1256.
  • Loading branch information
flamme authored May 19, 2021
1 parent e300350 commit 713b3a2
Show file tree
Hide file tree
Showing 2 changed files with 91 additions and 0 deletions.
1 change: 1 addition & 0 deletions tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ add_executable(
testXRunBehaviour.cpp
testStreamOpen.cpp
testStreamStates.cpp
testStreamFramesProcessed.cpp
)

target_link_libraries(testOboe gtest oboe)
90 changes: 90 additions & 0 deletions tests/testStreamFramesProcessed.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,90 @@
/*
* Copyright 2021 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

#include <gtest/gtest.h>
#include <oboe/Oboe.h>

#include <tuple>

using namespace oboe;

class MyCallback : public AudioStreamDataCallback {
public:
DataCallbackResult onAudioReady(AudioStream *oboeStream, void *audioData, int32_t numFrames) override {
return DataCallbackResult::Continue;
}
};

using StreamFramesProcessedParams = std::tuple<Direction, int32_t>;

class StreamFramesProcessed : public ::testing::Test,
public ::testing::WithParamInterface<StreamFramesProcessedParams> {

protected:
void TearDown() override;

static constexpr int PROCESS_TIME_SECONDS = 5;

AudioStreamBuilder mBuilder;
AudioStream *mStream = nullptr;
};

void StreamFramesProcessed::TearDown() {
if (mStream != nullptr) {
mStream->close();
mStream = nullptr;
}
}

TEST_P(StreamFramesProcessed, VerifyFramesProcessed) {
const Direction direction = std::get<0>(GetParam());
const int32_t sampleRate = std::get<1>(GetParam());

AudioStreamDataCallback *callback = new MyCallback();
mBuilder.setDirection(direction)
->setFormat(AudioFormat::Float)
->setSampleRate(sampleRate)
->setSampleRateConversionQuality(SampleRateConversionQuality::Medium)
->setPerformanceMode(PerformanceMode::LowLatency)
->setSharingMode(SharingMode::Exclusive)
->setDataCallback(callback);
mStream = nullptr;
Result r = mBuilder.openStream(&mStream);
ASSERT_EQ(r, Result::OK) << "Failed to open stream." << convertToText(r);

r = mStream->start();
ASSERT_EQ(r, Result::OK) << "Failed to start stream." << convertToText(r);
sleep(PROCESS_TIME_SECONDS);

// The frames written should be close to sampleRate * PROCESS_TIME_SECONDS
const int64_t framesWritten = mStream->getFramesWritten();
const int64_t framesRead = mStream->getFramesRead();
EXPECT_NEAR(framesWritten, sampleRate * PROCESS_TIME_SECONDS, sampleRate / 2);
EXPECT_NEAR(framesRead, sampleRate * PROCESS_TIME_SECONDS, sampleRate / 2);
}

INSTANTIATE_TEST_CASE_P(
StreamFramesProcessedTest,
StreamFramesProcessed,
::testing::Values(
StreamFramesProcessedParams({Direction::Output, 8000}),
StreamFramesProcessedParams({Direction::Output, 44100}),
StreamFramesProcessedParams({Direction::Output, 96000}),
StreamFramesProcessedParams({Direction::Input, 8000}),
StreamFramesProcessedParams({Direction::Input, 44100}),
StreamFramesProcessedParams({Direction::Input, 96000})
)
);

0 comments on commit 713b3a2

Please sign in to comment.