Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify pipestream by correctly interrupting a read on context cancellation. #497

Merged
merged 1 commit into from
Apr 2, 2021

Commits on Apr 2, 2021

  1. Simplify pipestream by correctly interrupting a read on context cance…

    …llation.
    
    golang/go#20280 (comment) has an
    excellent example on how to interrupt a read on context cancellation, which
    means we don't need to set a read deadline on every read attempt.  Then, the
    error handling is simplified, and as a side effect we aren't having spurious
    wakeups on idle fifos.
    
    This also means we no longer have a race on first read when the write end of a
    fifo isn't ready.
    
    Issue: #486
    jaqx0r committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    8dd02e8 View commit details
    Browse the repository at this point in the history