Propagate linkshared as appropriate in mozc_win32_cc_prod_binary
#1153
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows up to our previous commit [1], which was a preparation to address the symbol name mismatch in Mozc's TIP DLLs (google#1108) but accidentally removed 'linkshared' from them. While a subsequent commit [2] addressed the immediate issue by passing 'static_crt' to 'linkshared', strictly speaking they are two orthogonal concepts. Let's decouple them to avoid future confusions. There must be no immediate change in the final artifacts with this commit right now. [1]: bc546b2 [2]: 8d20ea6
yukawa
force-pushed
the
issue_1108_linkshared
branch
from
9e52c8c to
eaffb5e
Compare
|
We have merged your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This follows up to our previous commit (bc546b2) that was to simplify #1109 but accidentally removed 'linkshared' from Mozc's TIP DLL targets. While a subsequent commit (8d20ea6) addressed the immediate issue by passing 'static_crt' to 'linkshared', strictly speaking they are two orthogonal concepts. Let's decouple them to avoid future confusions.
There must be no immediate change in the final artifacts with this commit right now.
Issue IDs
mozc_tip32.dllbuilt with Bazel ismozc_tip.pdbrather thanmozc_tip32.dll.pdb#1108Steps to test new behaviors (if any)
bazelisk --bazelrc=windows.bazelrc build --config oss_windows --config release_build package