Make bzlmod repo rules compatible with Bazel 8 #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an upcoming behavior change in bzlmod --incompatible_use_plus_in_repo_names, which changes the separator character in canonical repo names from tilde `~` to plus `+` due to I/O performance issue in Windows. * bazelbuild/bazel#23127 The above flag is planned to be enabled by default in Bazel 8.0, which is expected to be released on November 2024. Let's update our custom repository rules so that they can continue working with Bazel 8.0.
yukawa
force-pushed
the
support_basel_23127
branch
from
6dc2d46 to
e78b252
Compare
|
We have merged your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is an upcoming behavior change in bzlmod
--incompatible_use_plus_in_repo_names, which changes the separator character in canonical repo names from tilde~to plus+due to I/O performance issue in Windows.--incompatible_use_plus_in_repo_namesbazelbuild/bazel#23127The above flag is planned to be enabled by default in Bazel 8.0, which is expected to be released on November 2024. Let's update our custom repository rules so that they can continue working with Bazel 8.0.
Issue IDs
This is a follow up to
Steps to test new behaviors (if any)
A clear and concise description about how to verify new behaviors (if any).
bazel build --config oss_linux package --config release_build --incompatible_use_plus_in_repo_names