upgrade Filament to 1.4.5 #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdata
previously approved these changes
Feb 3, 2020
cdata
approved these changes
Feb 3, 2020
elalish
added a commit
to elalish/model-viewer
that referenced
this pull request
Feb 4, 2020
upgrade Filament to 1.4.5 (google#982) * bumped filament version * updated cmgen * update goldens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This jump includes some major rendering improvements in Filament that I've been working with them on. The fidelity results match much better! I'm going to upload new goldens once I have access to my mac again due to #720.