Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny all default Clippy errors/warnings in github workflow #110

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

kdarkhan
Copy link
Collaborator

@kdarkhan kdarkhan commented Oct 29, 2023

When addressing this comment

You should at least trip the return which is not necessary here.

I noticed Clippy warnings such as warning: unneeded "return" statement and others like this do not produce non-zero status code which means the PR won't fail.

I am adding -D clippy::all in order to deny all default warnings to fail PRs.

Also adding a separate call to cargo clippy in directory i18n-helpers/fuzz because it is considered to be a separate workspace.

Copy link
Collaborator

@mgeisler mgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've always been on the fence about Clippy — but I guess it's good to enable it for a shared project like this.

@mgeisler mgeisler merged commit 86d47df into google:main Oct 30, 2023
5 checks passed
@kdarkhan
Copy link
Collaborator Author

I see, I haven't had much experience with Rust codebases. If this linter is over-restrictive I am ok with disabling the config as well.

@kdarkhan kdarkhan deleted the lint branch October 30, 2023 12:04
@mgeisler
Copy link
Collaborator

I see, I haven't had much experience with Rust codebases. If this linter is over-restrictive I am ok with disabling the config as well.

Let's use this config for a while and see if it bothers us 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants