Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add componentHanderConfig to configure upgrade on page load #4781

Merged
merged 5 commits into from
Oct 4, 2016

Conversation

AlexanderOtavka
Copy link
Contributor

Resolves #4780.

You can now, set window.componentHanderConfig = { preventAutoUpgrade: true }; before including the mdl script to disable the automatic upgrade of all components on page load.

I'm not sure how to document this change for the larger community, but I feel like it should be up on the MDL website.

Also, any suggestions for a better API for this feature are welcome.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@AlexanderOtavka
Copy link
Contributor Author

I signed it.

@googlebot
Copy link

CLAs look good, thanks!

@Garbee
Copy link
Collaborator

Garbee commented Sep 23, 2016

Let's discuss things in #4780 before reviewing this PR. I have some concerns which are best discussed in the main thread.

Thank you.

@Garbee
Copy link
Collaborator

Garbee commented Sep 23, 2016

LGTM awaiting review from @sgomes as well before merge.

@AlexanderOtavka
Copy link
Contributor Author

It looks like phantomjs is having trouble installing, but I don't think I caused that. My branch is a few commits behind, should I merge from the tip of mdl-1.x?

@Garbee
Copy link
Collaborator

Garbee commented Sep 23, 2016

Nah, shouldn't be necessary to rebase. I just restarted the builds. It is bitbucket throttling downloads because PhantomJS get's a lot. They really need to move their archive hosting elsewhere.

@AlexanderOtavka
Copy link
Contributor Author

Ok, good. And thanks for all the advice.

@sgomes
Copy link
Contributor

sgomes commented Sep 26, 2016

LGTM, thanks @AlexanderOtavka! I'll keep this open a few more days to see if any 1.2.x changes show up, as once this gets merged the next release will have to be on the 1.3.x range.

@AlexanderOtavka
Copy link
Contributor Author

Fantastic, happy to help.

@traviskaufman
Copy link
Contributor

@sgomes can we merge this?

@sgomes
Copy link
Contributor

sgomes commented Oct 4, 2016

@traviskaufman Yup. Let's officially start the 1.3 merge window with this.

@sgomes sgomes merged commit fb59319 into google:mdl-1.x Oct 4, 2016
@AlexanderOtavka AlexanderOtavka deleted the initial-upgrade-config branch October 4, 2016 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants