-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add componentHanderConfig to configure upgrade on page load #4781
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it. |
CLAs look good, thanks! |
Let's discuss things in #4780 before reviewing this PR. I have some concerns which are best discussed in the main thread. Thank you. |
LGTM awaiting review from @sgomes as well before merge. |
It looks like phantomjs is having trouble installing, but I don't think I caused that. My branch is a few commits behind, should I merge from the tip of |
Nah, shouldn't be necessary to rebase. I just restarted the builds. It is bitbucket throttling downloads because PhantomJS get's a lot. They really need to move their archive hosting elsewhere. |
Ok, good. And thanks for all the advice. |
LGTM, thanks @AlexanderOtavka! I'll keep this open a few more days to see if any 1.2.x changes show up, as once this gets merged the next release will have to be on the 1.3.x range. |
Fantastic, happy to help. |
@sgomes can we merge this? |
@traviskaufman Yup. Let's officially start the 1.3 merge window with this. |
Resolves #4780.
You can now, set
window.componentHanderConfig = { preventAutoUpgrade: true };
before including the mdl script to disable the automatic upgrade of all components on page load.I'm not sure how to document this change for the larger community, but I feel like it should be up on the MDL website.
Also, any suggestions for a better API for this feature are welcome.