Upgrade problem in dynamically created elements

[dopic]

Change in the function upgradeElementsInternal to enable the upgrade of child elements created by parent element's upgrade, like RippleContainerElement in Checkbox. The problem was happening when the element was created dynamically.

[surma]

Hey @dopic! Thanks for coming up with an implementation straight away.

Before I take a closer look: I was under the impression that the scenario you are describing was working with our implementation. Could you do us a favor whip up a CodePen showing a setup where creating an element dynamically wasn’t working as expected?

[dopic]

Hi @surma ! Thanks for the reply!

Sure, here is the link: http://codepen.io/dopic/pen/rOBPXo
Take a look at the rippleContainerElement created by the upgrade of Checkbox. It doesn't upgrade.

[surma]

@dopic Thank you! This is something that should be working, but obviously isn’t 😄

Looping in @Garbee and @jasonmayes to take a look at your code

[Garbee]

I'll take a closer look Monday when I have time. Weary about changing this
behavior though, may cause user code built to manage this situation to
break if not properly written.
On Aug 29, 2015 7:51 AM, "Surma" notifications@github.com wrote:

@dopic https://github.com/dopic Thank you! This is something that
should be working, but obviously isn’t [image: 😄]

Looping in @Garbee https://github.com/Garbee and @jasonmayes
https://github.com/jasonmayes to take a look at your code

—
Reply to this email directly or view it on GitHub
#1498 (comment)
.

[Garbee]

I'd say go ahead and merge. If someone coded a workaround to this then, sorry it may break. But it is a genuine bug-fix here.

[surma]

Thanks, @Garbee!

Merging.

[surma]

Cherry-picked to commit to mdl-1.0 as well

[dopic]

Thanks @Garbee and @surma!