Peek the connection to determine type of data on a CONNECT tunnel #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ther than assuming based on the port of the connect request
| r io.Reader | ||
| } | ||
|
|
||
| func (c *peekedConn) Read(buf []byte) (int, error) { return c.r.Read(buf) } |
There was a problem hiding this comment.
Add a comment to the exported function Read
|
LGTM - @adamtanner want to take a look? |
|
As a side note, this is the first step needed to make #31 work/not break. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peek the connection to determine type of data on a CONNECT tunnel, rather than assuming based on the port of the connect request.
Added test to verify this is working with multiple requests on the same connection.