Replace lazy Sequences by lazyMemoizedSequence #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
where the intermediate functions applied on the sequence are pure and
cost effective.
Unlike simple lazy values, intermediate functions applied in lazy
properties of Sequence types are computed repeatedly. For example,
square() is called each time x is read.
val x: Sequence<Int> by lazy { listOf(1, 2, 3).map { square(it) } }
lazyMemoizedSequence caches the values of the sequence.
Also replaced the stateful implementation of
KSClassDeclarationImpl.declarations by a stateless one.
jsjeon
approved these changes
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
where the intermediate functions applied on the sequence are pure and cost effective.
Unlike simple lazy values, intermediate functions applied in lazy properties of Sequence types are computed repeatedly. For example, square() is called each time x is read.
lazyMemoizedSequence caches the values of the sequence.
Also replaced the stateful implementation of
KSClassDeclarationImpl.declarations by a stateless one.