Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enabling KSP2 per module #2089

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

ansman
Copy link
Contributor

@ansman ansman commented Sep 6, 2024

With the change in #2034 a side effect was that KSP2 had to be enabled per Gradle project, not per module.

With this change a DSL property has been added to handle this.

@ting-yuan
Copy link
Collaborator

The test case needs to be updated:

    * What went wrong:
    Script compilation error:

      Line 7: ksp { useKsp2.set(true) }
                    ^ This API is experimental.It may be changed in the future without notice or might be removed.

Also lint failed in another place:

> Task :gradle-plugin:ktlint FAILED
/home/runner/work/ksp/ksp/gradle-plugin/src/main/kotlin/com/google/devtools/ksp/gradle/KspSubplugin.kt:68:1: Unused import

With the change in google#2034 a side effect was that KSP2 had to be enabled
per Gradle project, not per module.

With this change a DSL property has been added to handle this.
@ting-yuan ting-yuan merged commit 78e999b into google:main Sep 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants