Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Prefix PullSubscription and Topic testing functions with PubSub #989

Merged
merged 2 commits into from
May 6, 2020

Conversation

Harwayne
Copy link
Contributor

@Harwayne Harwayne commented May 2, 2020

Helps with #905.

Proposed Changes

  • Prefix PullSubscription and Topic testing functions with PubSub.
    • This is being done because the intevents version will soon need the same functions and will be given the non-prefixed names (as they will continue to exist past the next release).

There are no code changes other than renaming functions and a few types.

Release Note

NONE

This is being done because the intevents version will soon need the same functions and will be given the non-prefixed names (as they will continue to exist past the next release).
@googlebot googlebot added the cla: yes (override cla status due to multiple authors bug) label May 2, 2020
Copy link
Member

@yolocs yolocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, yolocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yolocs
Copy link
Member

yolocs commented May 4, 2020

/retest

5 similar comments
@Harwayne
Copy link
Contributor Author

Harwayne commented May 4, 2020

/retest

@Harwayne
Copy link
Contributor Author

Harwayne commented May 4, 2020

/retest

@Harwayne
Copy link
Contributor Author

Harwayne commented May 4, 2020

/retest

@Harwayne
Copy link
Contributor Author

Harwayne commented May 5, 2020

/retest

@Harwayne
Copy link
Contributor Author

Harwayne commented May 5, 2020

/retest

@knative-prow-robot knative-prow-robot merged commit 218ea15 into google:master May 6, 2020
@Harwayne Harwayne deleted the 905-move-pubsub-testing branch May 6, 2020 17:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants