Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Sources v1beta1 conversions #827

Merged
merged 14 commits into from
Apr 20, 2020

Conversation

Harwayne
Copy link
Contributor

@Harwayne Harwayne commented Apr 14, 2020

Helps with #615.

Proposed Changes

  • Adds the v1beta1 Source types to the API server.
    • CloudAuditLogsSource
    • CloudPubSubSource
    • CloudSchedulerSource
    • CloudStorageSource
  • Adds a conversion webhook that converts between v1alpha1 and v1beta1.
CloudAuditLogsSource, CloudPubSubSource, CloudSchedulerSource, and CloudStorageSource now exist in both v1alpha1 and v1beta1 versions. The versions are identical. All existing objects will continue to work. All valid configurations for the objects will continue to be valid. 

If you wish, you may start using the v1beta1 API surface. If you choose not to, then everything will continue to work as-is.

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes (override cla status due to multiple authors bug) label Apr 14, 2020
@Harwayne
Copy link
Contributor Author

/test pull-google-knative-gcp-integration-tests

2 similar comments
@Harwayne
Copy link
Contributor Author

/test pull-google-knative-gcp-integration-tests

@Harwayne
Copy link
Contributor Author

/test pull-google-knative-gcp-integration-tests

@Harwayne Harwayne changed the title [WIP] Sources v1beta conversions [WIP] Sources v1beta1 conversions Apr 14, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/convert/conversion_helper.go Do not exist 96.4%
pkg/apis/events/v1alpha1/cloudauditlogssource_conversion.go Do not exist 100.0%
pkg/apis/events/v1alpha1/cloudpubsubsource_conversion.go Do not exist 100.0%
pkg/apis/events/v1alpha1/cloudschedulersource_conversion.go Do not exist 100.0%
pkg/apis/events/v1alpha1/cloudstoragesource_conversion.go Do not exist 100.0%
pkg/apis/events/v1beta1/cloudauditlogssource_conversion.go Do not exist 100.0%
pkg/apis/events/v1beta1/cloudpubsubsource_conversion.go Do not exist 100.0%
pkg/apis/events/v1beta1/cloudschedulersource_conversion.go Do not exist 100.0%
pkg/apis/events/v1beta1/cloudstoragesource_conversion.go Do not exist 100.0%
pkg/apis/pubsub/v1alpha1/pullsubscription_conversion.go 90.9% 82.6% -8.3
pkg/apis/pubsub/v1alpha1/topic_conversion.go 80.0% 78.3% -1.7

@Harwayne Harwayne marked this pull request as ready for review April 16, 2020 15:34
@Harwayne Harwayne changed the title [WIP] Sources v1beta1 conversions Sources v1beta1 conversions Apr 16, 2020
@Harwayne
Copy link
Contributor Author

This is now ready for review.

Copy link
Member

@yolocs yolocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot merged commit b781032 into google:master Apr 20, 2020
@Harwayne Harwayne deleted the sources-conversion branch April 20, 2020 17:18
@knative-prow-robot
Copy link
Contributor

@Harwayne: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-google-knative-gcp-unit-tests 5e79a73 link /test pull-google-knative-gcp-unit-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants