-
Notifications
You must be signed in to change notification settings - Fork 74
Sources v1beta1 conversions #827
Sources v1beta1 conversions #827
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Harwayne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-google-knative-gcp-integration-tests |
2 similar comments
/test pull-google-knative-gcp-integration-tests |
/test pull-google-knative-gcp-integration-tests |
The following is the coverage report on the affected files.
|
This is now ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@Harwayne: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Helps with #615.
Proposed Changes