Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Follow ups from 784. #813

Merged
merged 1 commit into from
Apr 13, 2020
Merged

Follow ups from 784. #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/webhook/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ func NewConversionController(ctx context.Context, _ configmap.Watcher) *controll
},
},
},
// We don't want to alter the incoming context, so just pass it as-is.
func(ctx context.Context) context.Context {
return ctx
},
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/pubsub/v1alpha1/pullsubscription_conversion_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ var (
SubscriptionID: "subscriptionID",
}

// completePullSubscription is a PullSubscription with every filled in, except TypeMeta.
// completePullSubscription is a PullSubscription with every field filled in, except TypeMeta.
// TypeMeta is excluded because conversions do not convert it and this variable was created to
// test conversions.
completePullSubscription = &PullSubscription{
Expand Down