Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Create pkg/duck/{v1alpha1,v1beta1} #811

Merged
merged 2 commits into from
Apr 13, 2020

Conversation

Harwayne
Copy link
Contributor

Helps with #614.

This should have been in #779. Missing it was an oversight.

Proposed Changes

  • Move pkg/duck to pkg/duck/v1alpha1
  • Copy those interfaces into pkg/duck/v1beta1.

@googlebot googlebot added the cla: yes (override cla status due to multiple authors bug) label Apr 10, 2020
@Harwayne Harwayne mentioned this pull request Apr 10, 2020
Copy link
Member

@yolocs yolocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, yolocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Harwayne
Copy link
Contributor Author

/retest

@knative-prow-robot knative-prow-robot merged commit f0945e7 into google:master Apr 13, 2020
@Harwayne Harwayne deleted the duck-v1alpha1 branch April 13, 2020 21:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants