Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Add mains and yamls for security apis and controllers #711

Merged
merged 6 commits into from
Mar 27, 2020
Merged

Add mains and yamls for security apis and controllers #711

merged 6 commits into from
Mar 27, 2020

Conversation

yolocs
Copy link
Member

@yolocs yolocs commented Mar 25, 2020

Fixes #686

Proposed Changes

  • Added yamls under ./config/security so that it's separated from other stuff
  • Fixed a couple of small issues
  • Will add doc soon

Release Note

Add mains and yamls for security apis and controllers

@googlebot googlebot added the cla: yes (override cla status due to multiple authors bug) label Mar 25, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yolocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yolocs
Copy link
Member Author

yolocs commented Mar 25, 2020

/assign @nachocano

Harwayne
Harwayne reviewed Mar 26, 2020
View reviewed changes
cmd/security-controller/main.go Outdated Show resolved Hide resolved
cmd/security-webhook/main.go Show resolved Hide resolved
config/security/201-clusterrole.yaml Outdated Show resolved Hide resolved
config/security/201-clusterrole.yaml Outdated Show resolved Hide resolved
config/security/400-webhook-service.yaml Outdated Show resolved Hide resolved
config/security/500-controller.yaml Show resolved Hide resolved
config/security/500-webhook.yaml Show resolved Hide resolved
config/security/config-logging.yaml Show resolved Hide resolved
@yolocs yolocs requested a review from Harwayne March 26, 2020 17:23
@yolocs
Copy link
Member Author

yolocs commented Mar 27, 2020

@Harwayne If you don't mind, I'd like to keep the security.knative.dev in the PR and do a batch update in the follow-up one.

Harwayne
Harwayne reviewed Mar 27, 2020
View reviewed changes
Copy link
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Holding over the name issues. I don't have an objection to the current names, just want to make sure they are thought about before merging. Once you are happy with them, cancel the hold.

@yolocs
Copy link
Member Author

yolocs commented Mar 27, 2020

/unhold

Track naming change in #726

@capri-xiyue
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot merged commit 3dcffe7 into google:master Mar 27, 2020
@yolocs yolocs deleted the f/part branch March 27, 2020 21:01
@grac3gao-zz
Copy link
Contributor

/lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Harwayne Harwayne Harwayne left review comments

@nachocano nachocano nachocano left review comments

@capri-xiyue capri-xiyue Awaiting requested review from capri-xiyue

Assignees

@Harwayne Harwayne

@nachocano nachocano

@capri-xiyue capri-xiyue

Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add release artifact(s)
7 participants
@yolocs @knative-prow-robot @capri-xiyue @grac3gao-zz @Harwayne @nachocano @googlebot