Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Removing unused pubsubSecret from sources.spec #567

Merged
merged 54 commits into from
Feb 26, 2020

Conversation

nachocano
Copy link
Member

Fixes #548

Proposed Changes

  • 🧽 Remove pubSubSecret from the spec of current Sources. This was needed when we had the job-based reconcilers. We do not need it anymore, as we can just use spec.secret for the data plane.
  • 🧽 Added some validations and few other cleanups.

Release Note

The sources do not have a `spec.pubSubSecret` field anymore. If you were setting values there, you can just use `spec.secret` instead.

nachocano and others added 30 commits November 26, 2019 13:19
@nachocano
Copy link
Member Author

/assign @capri-xiyue

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/duck/v1alpha1/pubsub_types.go 6.2% 6.7% 0.4
pkg/apis/events/v1alpha1/cloudauditlogssource_validation.go 83.3% 81.0% -2.4
pkg/apis/events/v1alpha1/cloudpubsubsource_validation.go 88.9% 90.6% 1.7
pkg/apis/events/v1alpha1/cloudschedulersource_validation.go 93.1% 91.7% -1.4
pkg/apis/events/v1alpha1/cloudstoragesource_validation.go 93.5% 92.3% -1.2
pkg/apis/pubsub/v1alpha1/pullsubscription_validation.go 87.5% 88.4% 0.9
pkg/reconciler/pubsub/resources/pullsubscription.go 85.7% 100.0% 14.3

@knative-prow-robot
Copy link
Contributor

@nachocano: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-google-knative-gcp-go-coverage a3830db link /test pull-google-knative-gcp-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@capri-xiyue
Copy link
Contributor

/lgtm

@capri-xiyue
Copy link
Contributor

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: capri-xiyue, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [capri-xiyue,nachocano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 83f9e1c into google:master Feb 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove PubSubSecret from Sources
4 participants