This repository has been archived by the owner on Jun 19, 2022. It is now read-only.
add e2e test for Storage>Broker with PubSub Channel #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlopezgi
force-pushed
the
testE2EStorage
branch
from
0a9ffe3
to
85afea7
Compare
nlopezgi
changed the title
nlopezgi
force-pushed
the
testE2EStorage
branch
3 times, most recently
from
760c7c6
to
6f05b5d
Compare
nlopezgi
changed the title
nlopezgi
force-pushed
the
testE2EStorage
branch
from
6f05b5d
to
0a739c5
Compare
|
this is ready for review @chizhg @nachocano |
|
/lgtm Thank you so MUCH for tackling this and for all the nice refactoring!!! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nachocano, nlopezgi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second part of #511
Proposed Changes