Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

adding e2e test PubSubSource->Broker with PubSubChannel #550

Merged
merged 3 commits into from
Feb 19, 2020

Conversation

nlopezgi
Copy link
Contributor

@nlopezgi nlopezgi commented Feb 13, 2020

First part of #511

Proposed Changes

  • Add an e2e test that does CloudPubSubSource -> Broker backed by PubSub channel

Refactored some of the existing code for the test that uses Broker backed by PubSub channel with generic Source.
Left a couple of TODOs about refactoring and validations, need a bit of advice for those.

This PR is still a draft, my first attempt to create an e2e test, so not sure this is the right direction yet.

fyi @nachocano

@nlopezgi
Copy link
Contributor Author

fyi @chizhg

@nachocano nachocano changed the title adding e2e test PubSubSource->Broker with PubSubChannel [WIP] adding e2e test PubSubSource->Broker with PubSubChannel Feb 13, 2020
@nachocano
Copy link
Member

@nlopezgi just as fyi, by adding WIP in the description then is considered a draft and cannot be merged, until you un-WIP it..

Took a quick look, and yes, I agree, the less duplication we have the better. So I'd suggest you go forward with a refactor.
/assign @chizhg for suggestions on refactoring?

@chizhg
Copy link
Member

chizhg commented Feb 14, 2020

/cc

test/e2e/lib/pubsub.go Outdated Show resolved Hide resolved
test/e2e/test_broker_pubsub.go Outdated Show resolved Hide resolved
test/e2e/test_broker_pubsub.go Outdated Show resolved Hide resolved
@nachocano nachocano changed the title [WIP] adding e2e test PubSubSource->Broker with PubSubChannel adding e2e test PubSubSource->Broker with PubSubChannel Feb 18, 2020
@chizhg
Copy link
Member

chizhg commented Feb 18, 2020

/lgtm
/assign @nachocano

@nachocano
Copy link
Member

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano, nlopezgi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 818488f into google:master Feb 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants