This repository has been archived by the owner on Jun 19, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 74
adding e2e test PubSubSource->Broker with PubSubChannel #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fyi @chizhg |
nachocano
changed the title
adding e2e test PubSubSource->Broker with PubSubChannel
[WIP] adding e2e test PubSubSource->Broker with PubSubChannel
Feb 13, 2020
/cc |
chizhg
reviewed
Feb 18, 2020
nachocano
changed the title
[WIP] adding e2e test PubSubSource->Broker with PubSubChannel
adding e2e test PubSubSource->Broker with PubSubChannel
Feb 18, 2020
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nachocano, nlopezgi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of #511
Proposed Changes
Refactored some of the existing code for the test that uses Broker backed by PubSub channel with generic Source.
Left a couple of TODOs about refactoring and validations, need a bit of advice for those.
This PR is still a draft, my first attempt to create an e2e test, so not sure this is the right direction yet.
fyi @nachocano