fixed propagate publisher status and fixed the pubsubsecret

[capri-xiyue]

Fixes #

Proposed Changes

• fixed propagate publisher status
• fixed empty pubsubsecret

Release Note

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/events/v1alpha1/cloudschedulersource_validation.go	92.6%	92.9%	0.3
pkg/apis/events/v1alpha1/cloudstoragesource_validation.go	93.1%	93.3%	0.2
pkg/apis/pubsub/v1alpha1/topic_lifecycle.go	81.0%	60.7%	-20.2

[nachocano]

/lgtm
/approve

Thanks for the quick fix!

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: capri-xiyue, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [capri-xiyue,nachocano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nachocano]

BTW, have you tried gcloud with storage and scheduler with these fixes and they work?
If so, then we should cherry-pick to 0.12.

[capri-xiyue]

BTW, have you tried gcloud with storage and scheduler with these fixes and they work?
If so, then we should cherry-pick to 0.12.

The gcloud create trigger works.

However, when I tried to send event, it doesn't work for all four sources.
I checked the logs of default-broker-ingress, the error logs is as follows:
{"level":"warn","ts":1581573877.5656204,"logger":"fallback","caller":"http/transport.go:510","msg":"got an error from receiver fn","error":"error sending cloudevent: 500 Internal Server Error"} {"level":"warn","ts":1581573877.5656753,"logger":"fallback","caller":"http/transport.go:602","msg":"error returned from invokeReceiver","error":"error sending cloudevent: 500 Internal Server Error"}

I don't think it's related to this PR. Maybe because I use the latest serving and eventing. Will investigate further tomorrow.

[nachocano]

Yeah, that seems something different. We should cherry-pick to 0.12, and then test with that branch. We can do so tomorrow!

…

On Wed, Feb 12, 2020 at 10:31 PM capri-xiyue ***@***.***> wrote: BTW, have you tried gcloud with storage and scheduler with these fixes and they work? If so, then we should cherry-pick to 0.12. The gcloud create trigger works. However, when I tried to send event, it doesn't work for all four sources. I checked the logs of default-broker-ingress, the error logs is as follows: {"level":"warn","ts":1581573877.5656204,"logger":"fallback","caller":"http/transport.go:510","msg":"got an error from receiver fn","error":"error sending cloudevent: 500 Internal Server Error"} {"level":"warn","ts":1581573877.5656753,"logger":"fallback","caller":"http/transport.go:602","msg":"error returned from invokeReceiver","error":"error sending cloudevent: 500 Internal Server Error"} I don't think it's related to this PR. Maybe because I use the latest serving and eventing. Will investigate further tomorrow. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#549?email_source=notifications&email_token=ABD65DH5A5FEMPOEQLTPF3TRCTSK5A5CNFSM4KUK5XZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELTSKAQ#issuecomment-585573634>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABD65DAYR5Q4XTI3PPDYZPLRCTSK5ANCNFSM4KUK5XZA> .

[capri-xiyue]

It looks like we also need to cherry-pick this PR cda1f5c. My PR is based on it.

[nachocano]

OK, that should be fine. And that will help with the debugging as well..

…

On Wed, Feb 12, 2020 at 10:40 PM capri-xiyue ***@***.***> wrote: It looks like we also need to cherry-pick this PR cda1f5c <cda1f5c>. My PR is based on it. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#549?email_source=notifications&email_token=ABD65DBYUCARHDVZQCSFFXDRCTTNRA5CNFSM4KUK5XZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELTS52A#issuecomment-585576168>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABD65DGEL77RYUP3G7FRGQTRCTTNRANCNFSM4KUK5XZA> .