Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Upgrade to eventing v1 apis and eventing 0.22 #2199

Merged
merged 41 commits into from
May 4, 2021

Conversation

grantr
Copy link
Contributor

@grantr grantr commented Apr 29, 2021

Alternate, smaller-scope version of #2197, upgrading to 0.22 instead of head (0.23).

The v1beta1 versions of Broker and Trigger have been removed from upstream. The v1 version has an identical schema, so replacing is just import juggling.

This should unblock the auto dependency update.

Proposed Changes

  • 🗑️ Remove support for Broker and Trigger v1beta1

@google-cla google-cla bot added the cla: yes (override cla status due to multiple authors bug) label Apr 29, 2021
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/broker/v1/broker_defaults.go Do not exist 86.7%
pkg/apis/broker/v1/broker_lifecycle.go Do not exist 100.0%
pkg/apis/broker/v1/broker_types.go Do not exist 100.0%
pkg/apis/broker/v1/broker_validation.go Do not exist 100.0%
pkg/apis/broker/v1/register.go Do not exist 100.0%
pkg/apis/broker/v1/test_helper.go Do not exist 96.2%
pkg/apis/broker/v1/trigger_defaults.go Do not exist 100.0%
pkg/apis/broker/v1/trigger_lifecycle.go Do not exist 94.7%
pkg/apis/broker/v1/trigger_types.go Do not exist 100.0%
pkg/apis/broker/v1/trigger_validation.go Do not exist 100.0%
pkg/apis/convert/conversion_helper.go 96.4% 97.3% 0.9

@tommyreddad
Copy link
Contributor

/test pull-google-knative-gcp-wi-tests

@zhongduo
Copy link
Contributor

zhongduo commented May 4, 2021

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhongduo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 45ef817 into google:main May 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants