Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

[release-0.19] Upgrade trigger's serving subscriber version to v1 #1960

Conversation

MohamedElhawaty
Copy link
Contributor

Fixes #

This is to handle an issue related to setting the ApiVersion of the trigger's subscriber (knative service) to an unsupported version

Proposed Changes

Release Note


Docs

This is to handle an issue related to setting the ApiVersion of the
trigger's subscriber (knative service) to an unsupported version
@google-cla google-cla bot added the cla: yes (override cla status due to multiple authors bug) label Dec 1, 2020
@knative-prow-robot
Copy link
Contributor

Hi @MohamedElhawaty. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MohamedElhawaty
Copy link
Contributor Author

/ok-to-test

@knative-prow-robot
Copy link
Contributor

@MohamedElhawaty: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MohamedElhawaty
Copy link
Contributor Author

/ok-to-test

@eclipselu
Copy link
Contributor

eclipselu commented Dec 1, 2020

I think you'll need to also patch the github actions in release-0.19 branch, see: #1923

@MohamedElhawaty
Copy link
Contributor Author

/assign @nlopezgi
/assign @eclipselu

@eclipselu
Copy link
Contributor

/lgtm
/approve

@nlopezgi
Copy link
Contributor

nlopezgi commented Dec 2, 2020

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eclipselu, MohamedElhawaty, nlopezgi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit eae120d into google:release-0.19 Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm ok-to-test size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants