-
Notifications
You must be signed in to change notification settings - Fork 74
[release-0.19] Upgrade trigger's serving subscriber version to v1 #1960
[release-0.19] Upgrade trigger's serving subscriber version to v1 #1960
Conversation
This is to handle an issue related to setting the ApiVersion of the trigger's subscriber (knative service) to an unsupported version
Hi @MohamedElhawaty. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@MohamedElhawaty: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
I think you'll need to also patch the github actions in release-0.19 branch, see: #1923 |
/assign @nlopezgi |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eclipselu, MohamedElhawaty, nlopezgi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #
This is to handle an issue related to setting the ApiVersion of the trigger's subscriber (knative service) to an unsupported version
Proposed Changes
Release Note
Docs