Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

update prior to release 0.19 branch #1903

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

nlopezgi
Copy link
Contributor

Run instructions in https://github.com/knative/pkg/blob/8269222675d1050513fb7c72e2324171eb6abe18/RELEASE-LEADS.md prior to release:

RELEASE=0.19
REPO=git@github.com:knative/example.git

tmpdir=$(dirname $(mktemp -u))
cd ${tmpdir}
git clone ${REPO}
cd "$(basename "${REPO}" .git)"

if buoy check go.mod --domain knative.dev --release ${RELEASE} --verbose; then
  git checkout -b release-${RELEASE}
  ./hack/update-deps.sh --upgrade --release ${RELEASE}
  # consistency check, shouldnt do anything
  echo "There should be no changes to git:"
  git status
fi

send to master as there are changes.

@google-cla google-cla bot added the cla: yes (override cla status due to multiple authors bug) label Nov 10, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlopezgi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhongduo
Copy link
Contributor

/lgtm
/hold
I think we can wait for eventing 0.19 cut as the doc seems spend some efforts in the orders, but unhold if we want to do it now.

@nlopezgi
Copy link
Contributor Author

/lgtm
/hold
I think we can wait for eventing 0.19 cut as the doc seems spend some efforts in the orders, but unhold if we want to do it now.

Buoy is checking the upstream repos are ready and its determining they are with whatever criteria it currently uses. I don't think its necessary to wait here
/unhold

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants