Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Update broker deployments spec for better availability during upgrades #1690

Merged
merged 7 commits into from
Sep 17, 2020
Merged

Update broker deployments spec for better availability during upgrades #1690

merged 7 commits into from
Sep 17, 2020

Conversation

yolocs
Copy link
Member

@yolocs yolocs commented Sep 11, 2020

Fixes #611

Proposed Changes

  • Add MinReadySeconds=60s for broker deployments
  • Add a safer rolling update strategy
  • Relax probe period

Release Note

Update broker deployments spec for better availability during upgrades
- Add `MinReadySeconds=60s` for broker deployments
- Add a safer rolling update strategy
- Relax probe period

Docs

@google-cla google-cla bot added the cla: yes (override cla status due to multiple authors bug) label Sep 11, 2020
@yolocs yolocs requested review from grantr and removed request for ian-mi September 11, 2020 23:23
@Ectelion
Copy link
Contributor

/lgtm

@yolocs
Copy link
Member Author

yolocs commented Sep 15, 2020

/retest

@Ectelion
Copy link
Contributor

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ectelion, yolocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/utils/deployment.go 88.9% 90.0% 1.1

@yolocs
Copy link
Member Author

yolocs commented Sep 15, 2020

/retest

1 similar comment
@yolocs
Copy link
Member Author

yolocs commented Sep 16, 2020

/retest

@grac3gao-zz
Copy link
Contributor

/lgtm

@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-google-knative-gcp-integration-tests 2020-09-16 18:17:05.109 +0000 UTC
2020-09-16 18:32:35.171 +0000 UTC		 2/3
pull-google-knative-gcp-wi-tests 2020-09-16 16:30:05.361 +0000 UTC
2020-09-16 18:18:35.214 +0000 UTC		 2/3

Automatically retrying due to test flakiness...
/test pull-google-knative-gcp-integration-tests

@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-google-knative-gcp-integration-tests 2020-09-16 18:17:05.109 +0000 UTC 1/3
pull-google-knative-gcp-wi-tests 2020-09-16 16:30:05.361 +0000 UTC
2020-09-16 18:18:35.214 +0000 UTC
2020-09-16 18:32:35.171 +0000 UTC		 3/3

Automatically retrying due to test flakiness...
/test pull-google-knative-gcp-wi-tests

@yolocs
Copy link
Member Author

yolocs commented Sep 16, 2020

/retest

4 similar comments
@yolocs
Copy link
Member Author

yolocs commented Sep 16, 2020

/retest

@yolocs
Copy link
Member Author

yolocs commented Sep 16, 2020

/retest

@yolocs
Copy link
Member Author

yolocs commented Sep 16, 2020

/retest

@yolocs
Copy link
Member Author

yolocs commented Sep 17, 2020

/retest

@knative-prow-robot knative-prow-robot merged commit 82287ca into google:master Sep 17, 2020
@yolocs yolocs mentioned this pull request Oct 6, 2020
Closed
@yolocs yolocs deleted the b/fixforup branch November 23, 2020 16:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ectelion Ectelion Ectelion left review comments

@grac3gao-zz grac3gao-zz Awaiting requested review from grac3gao-zz

@grantr grantr Awaiting requested review from grantr

Assignees

@Ectelion Ectelion

@grac3gao-zz grac3gao-zz

Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broker ingress available during upgrade
6 participants
@yolocs @Ectelion @knative-prow-robot @knative-metrics-robot @grac3gao-zz @knative-test-reporter-robot