Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Promote CloudBuildSource to v1 API #1657

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Promote CloudBuildSource to v1 API #1657

merged 2 commits into from
Sep 1, 2020

Conversation

danyinggu
Copy link
Contributor

@danyinggu danyinggu commented Sep 1, 2020

Helps with #1413

Proposed Changes

  • Promote CloudBuildSource API to v1.

Release Note

Add v1 API for CloudBuildSource.

Docs

@google-cla google-cla bot added the cla: yes (override cla status due to multiple authors bug) label Sep 1, 2020
@danyinggu danyinggu requested review from capri-xiyue and removed request for ian-mi and grac3gao-zz September 1, 2020 19:51
@capri-xiyue
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: capri-xiyue, danyinggu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/events/v1/cloudbuildsource_defaults.go Do not exist 100.0%
pkg/apis/events/v1/cloudbuildsource_lifecycle.go Do not exist 100.0%
pkg/apis/events/v1/cloudbuildsource_types.go Do not exist 75.0%
pkg/apis/events/v1/cloudbuildsource_validation.go Do not exist 75.0%

@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-google-knative-gcp-wi-tests 2020-09-01 20:07:25.341 +0000 UTC 1/3

Automatically retrying due to test flakiness...
/test pull-google-knative-gcp-wi-tests

@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-google-knative-gcp-integration-tests 2020-09-01 20:07:25.346 +0000 UTC 1/3

Automatically retrying due to test flakiness...
/test pull-google-knative-gcp-integration-tests

@knative-prow-robot knative-prow-robot merged commit d48f304 into google:master Sep 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants