-
Notifications
You must be signed in to change notification settings - Fork 74
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grac3gao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
Maybe add Ian for a look.
The following jobs failed:
Failed non-flaky tests preventing automatic retry of pull-google-knative-gcp-wi-tests:
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
In case @ian-mi has comments
The following is the coverage report on the affected files.
|
/lgtm |
/unhold |
Fixes #1522
Proposed Changes
If the delivery is cancelled because of timeout, report event dispatch time without resp status code. In metric explorer, the dispatch time will look like: (trigger-actor-0 only has timeout event, trigger-actor-1 only has 2xx event)
Add and update some UT
Release Note
Docs