Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Issue #1494: Release-0.16 branch vendors an outdated Knative Eventing dependency #1495

Closed
wants to merge 1 commit into from
Closed

Issue #1494: Release-0.16 branch vendors an outdated Knative Eventing dependency #1495

wants to merge 1 commit into from

Conversation

Ectelion
Copy link
Contributor

Addresses #1494

@googlebot googlebot added the cla: yes (override cla status due to multiple authors bug) label Jul 21, 2020
@Ectelion Ectelion requested a review from nachocano July 21, 2020 22:53
@nachocano
Copy link
Member

/lgtm
/approve
/hold
until we get the other immutable fix in, so that we don't accidentally trigger two point releases

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ectelion, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nachocano
Copy link
Member

This is the issue we should cherry-pick to this branch, once we have the fix:
#1448

fyi @danyinggu, @bharattkukreja

@liu-cong
Copy link
Contributor

/retest

@knative-prow-robot
Copy link
Contributor

@Ectelion: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-google-knative-gcp-wi-tests 4e30f22 link /test pull-google-knative-gcp-wi-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-google-knative-gcp-wi-tests 2020-07-21 23:23:44.356 +0000 UTC
2020-07-21 23:55:14.602 +0000 UTC
2020-07-30 16:48:14.922 +0000 UTC
2020-07-30 17:20:14.888 +0000 UTC		 3/3

Job pull-google-knative-gcp-wi-tests expended all 3 retries without success.

@grac3gao-zz
Copy link
Contributor

grac3gao-zz commented Jul 30, 2020 •
edited
Loading

Checked the log from the failed WI test, it seems that this branch doesn't use some latest main branch updates to reduce flakiness, like the test sender Pod is still using an old version which doesn't include the retry for certain error code.

@grac3gao-zz
Copy link
Contributor

Sorry, I didn't realize it is for release-0.16 branch not for the main branch...then it might experience more flakiness...

@Ectelion Ectelion linked an issue Jul 31, 2020 that may be closed by this pull request
Release-0.16 branch vendors an outdated Knative Eventing 0.15 dependency #1494
Closed
@nachocano
Copy link
Member

Closing this one as we already pushed that change into 0.16 branch

@nachocano nachocano closed this Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Harwayne Harwayne Awaiting requested review from Harwayne

@liu-cong liu-cong Awaiting requested review from liu-cong

@nachocano nachocano Awaiting requested review from nachocano

Assignees

@nachocano nachocano

Labels
approved cla: yes (override cla status due to multiple authors bug) do-not-merge/hold lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release-0.16 branch vendors an outdated Knative Eventing 0.15 dependency
7 participants
@Ectelion @nachocano @knative-prow-robot @liu-cong @knative-test-reporter-robot @grac3gao-zz @googlebot