Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

set resource and requests limits for pulllsubscription receiver adapter #1327

Merged
merged 5 commits into from
Jun 25, 2020

Conversation

capri-xiyue
Copy link
Contributor

@capri-xiyue capri-xiyue commented Jun 23, 2020

Fixes #1105

Proposed Changes

-🧽 set resource and requests limits for pulllsubscription receiver adapter

Release Note

Adjusted pullsubscription receiver adapter cpu and memory requests and limits with
cpu request:500m, 
cpu limit: 600m, 
memory request:50mi, 
memory limit:600mi.
It should work with 1000 tps.

@googlebot googlebot added the cla: yes (override cla status due to multiple authors bug) label Jun 23, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: capri-xiyue

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@capri-xiyue
Copy link
Contributor Author

FYI: #1105 (comment)

@capri-xiyue
Copy link
Contributor Author

/retest

@capri-xiyue
Copy link
Contributor Author

capri-xiyue commented Jun 25, 2020

Updated number based on this sheet #1105 (comment) @nachocano

@capri-xiyue
Copy link
Contributor Author

/retest

@capri-xiyue
Copy link
Contributor Author

/test pull-google-knative-gcp-unit-tests

@nachocano
Copy link
Member

/lgtm

Thanks @capri-xiyue !!!

@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-google-knative-gcp-integration-tests pull-google-knative-gcp-integration-tests
pull-google-knative-gcp-integration-tests
2/3
pull-google-knative-gcp-wi-tests pull-google-knative-gcp-wi-tests
pull-google-knative-gcp-wi-tests
2/3

Automatically retrying due to test flakiness...
/test pull-google-knative-gcp-integration-tests

@knative-prow-robot knative-prow-robot merged commit 503f626 into google:master Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set resource requests and limits for PullSubscription receive adapter
5 participants