Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Remove spec.googleServiceAccount in v1alpha1 #1249

Merged
merged 2 commits into from
Jun 9, 2020

Conversation

grac3gao-zz
Copy link
Contributor

@grac3gao-zz grac3gao-zz commented Jun 9, 2020

Fixes #1205

Proposed Changes

  • Removing spec.googleServiceAccount, together, deleting any controller logic related on googleServiceAccount

Release Note


`spec.googleServiceAccount` has been removed. All automatic Workload Identity related controller work is now handled via `config-gcp-auth`.

@googlebot googlebot added the cla: yes (override cla status due to multiple authors bug) label Jun 9, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/duck/v1alpha1/credentials.go 79.2% 100.0% 20.8
pkg/reconciler/events/auditlogs/auditlogs.go 89.6% 87.0% -2.6
pkg/reconciler/events/build/build.go 78.6% 57.1% -21.4
pkg/reconciler/events/pubsub/pubsub.go 78.6% 57.1% -21.4
pkg/reconciler/events/scheduler/scheduler.go 81.4% 78.6% -2.9
pkg/reconciler/events/storage/storage.go 74.7% 72.5% -2.2
pkg/reconciler/identity/reconciler.go 65.2% 65.9% 0.7
pkg/reconciler/intevents/pullsubscription/resources/receive_adapter.go 85.3% 87.1% 1.8
pkg/reconciler/intevents/topic/resources/publisher.go 81.2% 84.6% 3.4
pkg/reconciler/messaging/channel/channel.go 79.9% 78.0% -1.9

@nachocano
Copy link
Member

/approve
/lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grac3gao, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Harwayne
Copy link
Contributor

Harwayne commented Jun 9, 2020

/hold

Please add a release notes section saying that the field has been removed. The release-notes section is what we use to create the release notes and this is definitely a user-visible change.

@grac3gao-zz
Copy link
Contributor Author

@Harwayne Done. Sorry, I forget to add release note....

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove spec.googleServiceAccount in v1alpha1
8 participants