Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Provide the default GCP auth during the creation of the PullSubscription for E2E #1220

Merged
merged 2 commits into from
Jun 5, 2020

Conversation

Harwayne
Copy link
Contributor

@Harwayne Harwayne commented Jun 4, 2020

Proposed Changes

  • Provide the default GCP auth during the creation of the PullSubscription for E2E
    • This doesn't alter the outcome of the tests, but before this change an error log was generated stating Failed to get the GCPAuthDefaults.

Release Note

NONE

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: yes (override cla status due to multiple authors bug) label Jun 4, 2020
@grac3gao-zz
Copy link
Contributor

/lgtm

@Harwayne
Copy link
Contributor Author

Harwayne commented Jun 4, 2020

/retest

@capri-xiyue
Copy link
Contributor

capri-xiyue commented Jun 4, 2020

Can you also help change similar things for other resources under https://github.com/google/knative-gcp/tree/master/pkg/reconciler/testing like

s.SetDefaults(context.Background())
?

@Harwayne
Copy link
Contributor Author

Harwayne commented Jun 4, 2020

/retest

@Harwayne
Copy link
Contributor Author

Harwayne commented Jun 4, 2020

Can you also help change similar things for other resources under https://github.com/google/knative-gcp/tree/master/pkg/reconciler/testing like

s.SetDefaults(context.Background())

?

Done.

At least the ones I noticed.

@capri-xiyue
Copy link
Contributor

/lgtm

@grac3gao-zz
Copy link
Contributor

/retest

@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-google-knative-gcp-wi-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-google-knative-gcp-wi-tests:

github.com/google/knative-gcp/test/e2e.TestGCPBroker

@nachocano
Copy link
Member

/retest

@knative-prow-robot knative-prow-robot merged commit f9f89db into google:master Jun 5, 2020
@Harwayne Harwayne deleted the e2e-ps-gcpauth branch June 5, 2020 16:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants