Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Pin to latest pubsub protocol to get bug fix #1208

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

liu-cong
Copy link
Contributor

@liu-cong liu-cong commented Jun 4, 2020

Fixes #1178

Proposed Changes

Release Note


Docs

@googlebot googlebot added the cla: yes (override cla status due to multiple authors bug) label Jun 4, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liu-cong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@grac3gao-zz
Copy link
Contributor

/lgtm

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/broker/handler/handler.go 85.7% 86.4% 0.6
pkg/broker/handler/processors/deliver/processor.go 83.3% 84.1% 0.8
pkg/broker/ingress/handler.go 90.9% 91.2% 0.3

@nachocano
Copy link
Member

/lgtm

@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-google-knative-gcp-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-google-knative-gcp-integration-tests:

github.com/google/knative-gcp/test/e2e.TestChannelTracing
github.com/google/knative-gcp/test/e2e.TestChannelTracing/includes_incoming_trace_id

@liu-cong liu-cong mentioned this pull request Jun 4, 2020
@liu-cong
Copy link
Contributor Author

liu-cong commented Jun 4, 2020

/retest

@knative-prow-robot knative-prow-robot merged commit 3f782ec into google:master Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-event message in pubsub causes fanout/retry to panic (SDK bug)
7 participants