added or modified smoke test of four sources and gcp broker #1161

capri-xiyue · 2020-05-28T22:58:27Z

Fixes #909 #1165

Proposed Changes

modified or added smoke test of pubsub, storage, scheduler, auditlogs sources
added smoke test of gcp broker
use "github.com/google/knative-gcp/pkg/apis/broker/v1beta1" when creating gcp broker instead of "knative.dev/eventing/pkg/apis/eventing/v1beta1"

Release Note

Docs

knative-prow-robot · 2020-05-28T22:58:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: capri-xiyue

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [capri-xiyue]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

capri-xiyue · 2020-05-28T23:14:09Z

/retest

test/e2e/lib/auditlogs.go

capri-xiyue · 2020-05-29T03:57:57Z

At first, I tried to avoid using methods like

knative-gcp/test/e2e/lib/creation.go

Line 75 in 53a1bd6

    
           func (c *Client) CreateStorageOrFail(storage *eventsv1alpha1.CloudStorageSource) {

since it has tracker that we don't need to use in smoke test happy path since we will delete the source by ourselves in the smoke tests(

knative-gcp/test/e2e/lib/creation.go

Line 83 in 53a1bd6

c.Tracker.AddObj(storage)

).
However, if I don't use that method, it will make the code kind of complex since I need to handle unhappy paths that the test fail and but we still need to delete the sources no matter what.

Therefore, in the end, I still choose to use

knative-gcp/test/e2e/lib/creation.go

Line 75 in 53a1bd6

    
           func (c *Client) CreateStorageOrFail(storage *eventsv1alpha1.CloudStorageSource) {

with c.Tracker.AddObj(xxxx). The side effect is that when the test passes, if you run go test -v, it will show similar logs that `tracker can't delete source, not found'

capri-xiyue · 2020-05-29T18:46:37Z

In addition, I found one bug of sources(source can still be ready even though the sink(k8s service) doesn't exist). Already filed another issue for that bug #1171

capri-xiyue · 2020-05-29T20:10:02Z

/test pull-google-knative-gcp-integration-tests

chizhg · 2020-06-01T20:43:46Z

lgtm from my side.
Defer to @nachocano and @ericlem for applying the /lgtm label.

capri-xiyue · 2020-06-01T20:49:32Z

/retest

test/e2e/lib/deletion.go

test/e2e/lib/get.go

test/e2e/lib/resources/knative_gcp.go

test/e2e/test_auditlogs.go

test/e2e/test_gcp_broker.go

test/e2e/test_pubsub.go

test/e2e/test_scheduler.go

test/e2e/test_storage.go

nachocano · 2020-06-01T21:05:48Z

/lgtm
/hold
in case you want to do those changes now. Otherwise in a follow up is fine. Please do unhold if so

capri-xiyue · 2020-06-01T21:17:42Z

/retest

capri-xiyue · 2020-06-01T21:17:55Z

/unhold

nachocano · 2020-06-01T21:22:37Z

test/e2e/lib/resources/constants.go

+
+// WaitDeletionTime for deleting resources
+const (
+	WaitDeletionTime  = 20 * time.Second


sounds good, will put this one to 10, and then in the few places you need 20, just multiply?

I see you went with 20 everywhere. My only worry is that tests will last even longer... But I'm ok if you leave it as is

knative-metrics-robot · 2020-06-01T21:26:46Z

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/intevents/reconciler.go	78.2%	78.4%	0.2

chizhg · 2020-06-01T21:35:02Z

/lgtm

capri-xiyue · 2020-06-01T21:54:40Z

/test pull-google-knative-gcp-integration-tests

capri-xiyue · 2020-06-01T22:42:52Z

/test pull-google-knative-gcp-integration-tests

knative-test-reporter-robot · 2020-06-02T00:21:52Z

The following jobs failed:

Test name	Triggers	Retries
pull-google-knative-gcp-integration-tests		0/3
pull-google-knative-gcp-wi-tests	pull-google-knative-gcp-wi-tests pull-google-knative-gcp-wi-tests	2/3

Automatically retrying due to test flakiness...
/test pull-google-knative-gcp-wi-tests

modified smoke test of CloudPubSubSource

ffdbf08

knative-prow-robot added the do-not-merge/work-in-progress label May 28, 2020

knative-prow-robot requested review from ericlem and grac3gao-zz May 28, 2020 22:58

knative-prow-robot added the approved label May 28, 2020

googlebot added the cla: yes (override cla status due to multiple authors bug) label May 28, 2020

knative-prow-robot added the size/L label May 28, 2020

capri-xiyue requested review from chizhg and nachocano and removed request for grac3gao-zz May 28, 2020 22:58

capri-xiyue added 4 commits May 28, 2020 16:51

fixed unit tests and renamed methods

7645324

refactored duplicate code

4585715

refactored the code

26de5c9

added smoke test for storage schcheduler and pubsub sources

fe3563d

knative-prow-robot added size/XL and removed size/L labels May 29, 2020

capri-xiyue changed the title ~~[WIP]modified smoke test of CloudPubSubSource~~ [WIP]modified smoke test of four sources May 29, 2020

capri-xiyue changed the title ~~[WIP]modified smoke test of four sources~~ modified smoke test of four sources May 29, 2020

knative-prow-robot removed the do-not-merge/work-in-progress label May 29, 2020

capri-xiyue changed the title ~~modified smoke test of four sources~~ added or modified smoke test of four sources May 29, 2020

chizhg reviewed May 29, 2020

View reviewed changes

test/e2e/lib/auditlogs.go Outdated Show resolved Hide resolved

removed redundant else

2394587

added smoke test of gcp broker

acbf3c6

capri-xiyue changed the title ~~added or modified smoke test of four sources~~ added or modified smoke test of four sources and gcp broker May 29, 2020

renaming

3885d9e

nachocano reviewed Jun 1, 2020

View reviewed changes

test/e2e/lib/deletion.go Outdated Show resolved Hide resolved

nachocano reviewed Jun 1, 2020

View reviewed changes

test/e2e/lib/get.go Outdated Show resolved Hide resolved

nachocano reviewed Jun 1, 2020

View reviewed changes

test/e2e/lib/resources/knative_gcp.go Show resolved Hide resolved

nachocano reviewed Jun 1, 2020

View reviewed changes

test/e2e/test_auditlogs.go Outdated Show resolved Hide resolved

nachocano reviewed Jun 1, 2020

View reviewed changes

test/e2e/test_gcp_broker.go Outdated Show resolved Hide resolved

nachocano reviewed Jun 1, 2020

View reviewed changes

test/e2e/test_pubsub.go Outdated Show resolved Hide resolved

nachocano reviewed Jun 1, 2020

View reviewed changes

test/e2e/test_scheduler.go Outdated Show resolved Hide resolved

nachocano reviewed Jun 1, 2020

View reviewed changes

test/e2e/test_storage.go Outdated Show resolved Hide resolved

knative-prow-robot added the do-not-merge/hold label Jun 1, 2020

knative-prow-robot assigned nachocano Jun 1, 2020

knative-prow-robot added the lgtm label Jun 1, 2020

added constants

2b3093d

knative-prow-robot removed the lgtm label Jun 1, 2020

knative-prow-robot removed the do-not-merge/hold label Jun 1, 2020

fixed typo

555dcc9

nachocano reviewed Jun 1, 2020

View reviewed changes

knative-prow-robot assigned chizhg Jun 1, 2020

knative-prow-robot added the lgtm label Jun 1, 2020

knative-prow-robot merged commit f016967 into google:master Jun 2, 2020

grantr mentioned this pull request Jun 2, 2020

Test deletion of gcp broker also deletes GCP resources #1165

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added or modified smoke test of four sources and gcp broker #1161

added or modified smoke test of four sources and gcp broker #1161

capri-xiyue commented May 28, 2020 •

edited

Loading

knative-prow-robot commented May 28, 2020

capri-xiyue commented May 28, 2020

capri-xiyue commented May 29, 2020 •

edited

Loading

capri-xiyue commented May 29, 2020

capri-xiyue commented May 29, 2020

chizhg commented Jun 1, 2020

capri-xiyue commented Jun 1, 2020

nachocano commented Jun 1, 2020 •

edited

Loading

capri-xiyue commented Jun 1, 2020

capri-xiyue commented Jun 1, 2020

nachocano Jun 1, 2020

nachocano Jun 1, 2020

knative-metrics-robot commented Jun 1, 2020

chizhg commented Jun 1, 2020

capri-xiyue commented Jun 1, 2020

capri-xiyue commented Jun 1, 2020

knative-test-reporter-robot commented Jun 2, 2020

added or modified smoke test of four sources and gcp broker #1161

added or modified smoke test of four sources and gcp broker #1161

Conversation

capri-xiyue commented May 28, 2020 • edited Loading

Proposed Changes

knative-prow-robot commented May 28, 2020

capri-xiyue commented May 28, 2020

capri-xiyue commented May 29, 2020 • edited Loading

capri-xiyue commented May 29, 2020

capri-xiyue commented May 29, 2020

chizhg commented Jun 1, 2020

capri-xiyue commented Jun 1, 2020

nachocano commented Jun 1, 2020 • edited Loading

capri-xiyue commented Jun 1, 2020

capri-xiyue commented Jun 1, 2020

nachocano Jun 1, 2020

Choose a reason for hiding this comment

nachocano Jun 1, 2020

Choose a reason for hiding this comment

knative-metrics-robot commented Jun 1, 2020

chizhg commented Jun 1, 2020

capri-xiyue commented Jun 1, 2020

capri-xiyue commented Jun 1, 2020

knative-test-reporter-robot commented Jun 2, 2020

capri-xiyue commented May 28, 2020 •

edited

Loading

capri-xiyue commented May 29, 2020 •

edited

Loading

nachocano commented Jun 1, 2020 •

edited

Loading