Create brokercell on demand #1132
Conversation
|
Skipping CI for Draft Pull Request. |
|
cc @yolocs |
|
/assign @yolocs |
…rokercell-creation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liu-cong, yolocs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-google-knative-gcp-go-coverage |
|
The following is the coverage report on the affected files.
|
| @@ -287,7 +277,7 @@ func (r *Reconciler) reconcileDecouplingTopicAndSubscription(ctx context.Context | |||
| topic, err = client.CreateTopicWithConfig(ctx, topicID, topicConfig) | |||
| if err != nil { | |||
| logger.Error("Failed to create Pub/Sub topic", zap.Error(err)) | |||
| b.Status.MarkTopicFailed("CreationFailed", "Topic creation failed: %w", err) | |||
| b.Status.MarkTopicFailed("TopicCreationFailed", "Topic creation failed: %w", err) | |||
There was a problem hiding this comment.
This is the REASON field when you do kubectl get broker my-broker.
| } | ||
| } | ||
| if err == nil { | ||
| r.Recorder.Eventf(b, corev1.EventTypeNormal, brokerCellCreated, "Created brokercell %s/%s", bc.Namespace, bc.Name) |
There was a problem hiding this comment.
nit: created => ensured. Could be confusing if there is an existing brokercell.
There was a problem hiding this comment.
Actually I think create is accurate here: Line 53 tries to create a brokercell, and this line only records the event when there is no error.
|
The following jobs failed:
Automatically retrying due to test flakiness... |
Ref #867
Fixes #1145
Proposed Changes
Release Note
Docs