This repository has been archived by the owner on Jun 19, 2022. It is now read-only.
Add k8s service account under identity spec #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grac3gao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nachocano
reviewed
May 26, 2020
Harwayne
reviewed
May 26, 2020
Harwayne
reviewed
May 26, 2020
pkg/apis/events/v1alpha1/cloudauditlogssource_validation_test.go
Outdated
Show resolved
Hide resolved
pkg/apis/events/v1beta1/cloudauditlogssource_validation_test.go
Outdated
Show resolved
Hide resolved
pkg/apis/events/v1beta1/cloudschedulersource_validation_test.go
Outdated
Show resolved
Hide resolved
|
/retest |
|
/retest
…On Tue, May 26, 2020 at 1:10 PM Knative test reporter robot < ***@***.***> wrote:
The following jobs failed:
Test name Triggers Retries
pull-google-knative-gcp-wi-tests pull-google-knative-gcp-wi-tests
<https://prow.knative.dev/view/gcs/knative-prow/pr-logs/pull/google_knative-gcp/1128/pull-google-knative-gcp-wi-tests/1265359107754299396>
pull-google-knative-gcp-wi-tests
<https://prow.knative.dev/view/gcs/knative-prow/pr-logs/pull/google_knative-gcp/1128/pull-google-knative-gcp-wi-tests/1265367412207783936>
2/3
Automatically retrying due to test flakiness...
/test pull-google-knative-gcp-wi-tests
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1128 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABD65DGAG5R2SU6MONYDLDLRTQO3TANCNFSM4NKZMS6Q>
.
|
|
/retest |
|
/lgtm |
|
The following jobs failed:
Automatically retrying due to test flakiness... |
|
/lgtm
…On Tue, May 26, 2020 at 5:36 PM Knative Metrics Robot < ***@***.***> wrote:
The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage
report
File Old Coverage New Coverage Delta
pkg/apis/convert/conversion_helper.go
<https://storage.cloud.google.com/knative-prow/pr-logs/pull/google_knative-gcp/1128/pull-google-knative-gcp-go-coverage/1265440645053419521/artifacts/line-cov.html#file0>
96.4% 94.3% -2.1
pkg/apis/duck/v1alpha1/credentials.go
<https://storage.cloud.google.com/knative-prow/pr-logs/pull/google_knative-gcp/1128/pull-google-knative-gcp-go-coverage/1265440645053419521/artifacts/line-cov.html#file1>
100.0% 80.0% -20.0
pkg/apis/events/v1alpha1/cloudauditlogssource_validation.go
<https://storage.cloud.google.com/knative-prow/pr-logs/pull/google_knative-gcp/1128/pull-google-knative-gcp-go-coverage/1265440645053419521/artifacts/line-cov.html#file9>
88.9% 94.7% 5.8
pkg/apis/events/v1alpha1/cloudbuildsource_validation.go
<https://storage.cloud.google.com/knative-prow/pr-logs/pull/google_knative-gcp/1128/pull-google-knative-gcp-go-coverage/1265440645053419521/artifacts/line-cov.html#file11>
88.2% 88.9% 0.7
pkg/apis/events/v1alpha1/cloudpubsubsource_validation.go
<https://storage.cloud.google.com/knative-prow/pr-logs/pull/google_knative-gcp/1128/pull-google-knative-gcp-go-coverage/1265440645053419521/artifacts/line-cov.html#file13>
93.1% 93.3% 0.2
pkg/apis/events/v1alpha1/cloudschedulersource_validation.go
<https://storage.cloud.google.com/knative-prow/pr-logs/pull/google_knative-gcp/1128/pull-google-knative-gcp-go-coverage/1265440645053419521/artifacts/line-cov.html#file15>
95.2% 100.0% 4.8
pkg/apis/events/v1alpha1/cloudstoragesource_validation.go
<https://storage.cloud.google.com/knative-prow/pr-logs/pull/google_knative-gcp/1128/pull-google-knative-gcp-go-coverage/1265440645053419521/artifacts/line-cov.html#file18>
94.1% 100.0% 5.9
pkg/apis/intevents/v1alpha1/pullsubscription_conversion.go
<https://storage.cloud.google.com/knative-prow/pr-logs/pull/google_knative-gcp/1128/pull-google-knative-gcp-go-coverage/1265440645053419521/artifacts/line-cov.html#file27> Do
not exist 82.6%
pkg/apis/intevents/v1alpha1/pullsubscription_types.go
<https://storage.cloud.google.com/knative-prow/pr-logs/pull/google_knative-gcp/1128/pull-google-knative-gcp-go-coverage/1265440645053419521/artifacts/line-cov.html#file28> Do
not exist 92.9%
pkg/apis/intevents/v1alpha1/topic_types.go
<https://storage.cloud.google.com/knative-prow/pr-logs/pull/google_knative-gcp/1128/pull-google-knative-gcp-go-coverage/1265440645053419521/artifacts/line-cov.html#file29> Do
not exist 100.0%
pkg/apis/intevents/v1beta1/pullsubscription_types.go
<https://storage.cloud.google.com/knative-prow/pr-logs/pull/google_knative-gcp/1128/pull-google-knative-gcp-go-coverage/1265440645053419521/artifacts/line-cov.html#file30> Do
not exist 92.9%
pkg/apis/intevents/v1beta1/topic_types.go
<https://storage.cloud.google.com/knative-prow/pr-logs/pull/google_knative-gcp/1128/pull-google-knative-gcp-go-coverage/1265440645053419521/artifacts/line-cov.html#file31> Do
not exist 100.0%
pkg/apis/messaging/v1alpha1/channel_conversion.go
<https://storage.cloud.google.com/knative-prow/pr-logs/pull/google_knative-gcp/1128/pull-google-knative-gcp-go-coverage/1265440645053419521/artifacts/line-cov.html#file32> Do
not exist 93.9%
pkg/apis/messaging/v1alpha1/channel_defaults.go
<https://storage.cloud.google.com/knative-prow/pr-logs/pull/google_knative-gcp/1128/pull-google-knative-gcp-go-coverage/1265440645053419521/artifacts/line-cov.html#file33>
100.0% 88.9% -11.1
pkg/apis/messaging/v1alpha1/channel_validation.go
<https://storage.cloud.google.com/knative-prow/pr-logs/pull/google_knative-gcp/1128/pull-google-knative-gcp-go-coverage/1265440645053419521/artifacts/line-cov.html#file35>
84.2% 90.0% 5.8
pkg/reconciler/intevents/pullsubscription/resources/receive_adapter.go
<https://storage.cloud.google.com/knative-prow/pr-logs/pull/google_knative-gcp/1128/pull-google-knative-gcp-go-coverage/1265440645053419521/artifacts/line-cov.html#file44> Do
not exist 82.9%
pkg/reconciler/intevents/resources/pullsubscription.go
<https://storage.cloud.google.com/knative-prow/pr-logs/pull/google_knative-gcp/1128/pull-google-knative-gcp-go-coverage/1265440645053419521/artifacts/line-cov.html#file45> Do
not exist 100.0%
pkg/reconciler/intevents/resources/topic.go
<https://storage.cloud.google.com/knative-prow/pr-logs/pull/google_knative-gcp/1128/pull-google-knative-gcp-go-coverage/1265440645053419521/artifacts/line-cov.html#file46> Do
not exist 100.0%
pkg/reconciler/intevents/topic/resources/publisher.go
<https://storage.cloud.google.com/knative-prow/pr-logs/pull/google_knative-gcp/1128/pull-google-knative-gcp-go-coverage/1265440645053419521/artifacts/line-cov.html#file47> Do
not exist 76.5%
pkg/reconciler/messaging/channel/channel.go
<https://storage.cloud.google.com/knative-prow/pr-logs/pull/google_knative-gcp/1128/pull-google-knative-gcp-go-coverage/1265440645053419521/artifacts/line-cov.html#file48>
79.6% 79.9% 0.3
pkg/reconciler/pubsub/pullsubscription/resources/receive_adapter.go
<https://storage.cloud.google.com/knative-prow/pr-logs/pull/google_knative-gcp/1128/pull-google-knative-gcp-go-coverage/1265440645053419521/artifacts/line-cov.html#file51>
87.5% 83.3% -4.2
pkg/reconciler/pubsub/topic/resources/publisher.go
<https://storage.cloud.google.com/knative-prow/pr-logs/pull/google_knative-gcp/1128/pull-google-knative-gcp-go-coverage/1265440645053419521/artifacts/line-cov.html#file54>
85.7% 77.8% -7.9
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#1128 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABD65DBRLR6UNFBYJTFMQUDRTROCPANCNFSM4NKZMS6Q>
.
|
ian-mi
pushed a commit
to ian-mi/knative-gcp
that referenced
this pull request
May 29, 2020
* add k8s service account * change * add intevents * add channel * change channel
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes
Release Note
Docs