Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Reconcilers for PullSubscription and Topic in intevents #1013

Merged
merged 14 commits into from
May 12, 2020

Conversation

Harwayne
Copy link
Contributor

@Harwayne Harwayne commented May 6, 2020

Helps with #905

Proposed Changes

  • Add the PullSubscription and Topic in internal.events.cloud.google.com to the Webhook.
  • Add the controllers for those types.
    • These are exact copies of the versions in pkg/reconciler/pubsub. The only changes are those needed by the compiler.
    • We decided to copy-paste the code, rather than having one code path, because we expect the old reconcilers to be removed in 0.16, which is in less than three weeks. It seemed easier to manually ensure all changes occur in both places, rather than refactoring everything to allow a single code path to work.

Release Note

NONE

@googlebot googlebot added the cla: yes (override cla status due to multiple authors bug) label May 6, 2020
@Harwayne Harwayne marked this pull request as ready for review May 8, 2020 17:32
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/intevents/controller.go Do not exist 50.0%
pkg/reconciler/intevents/pullsubscription/keda/controller.go Do not exist 92.0%
pkg/reconciler/intevents/pullsubscription/keda/pullsubscription.go Do not exist 64.3%
pkg/reconciler/intevents/pullsubscription/keda/resources/names.go Do not exist 100.0%
pkg/reconciler/intevents/pullsubscription/keda/resources/scaled_object.go Do not exist 100.0%
pkg/reconciler/intevents/pullsubscription/resources/labels.go Do not exist 0.0%
pkg/reconciler/intevents/pullsubscription/resources/names.go Do not exist 100.0%
pkg/reconciler/intevents/pullsubscription/resources/receive_adapter.go Do not exist 87.5%
pkg/reconciler/intevents/pullsubscription/static/controller.go Do not exist 91.7%
pkg/reconciler/intevents/pullsubscription/static/pullsubscription.go Do not exist 75.0%
pkg/reconciler/intevents/reconciler.go Do not exist 73.7%
pkg/reconciler/intevents/resources/annotations.go Do not exist 100.0%
pkg/reconciler/intevents/resources/labels.go Do not exist 100.0%
pkg/reconciler/intevents/resources/pullsubscription.go Do not exist 100.0%
pkg/reconciler/intevents/resources/topic.go Do not exist 100.0%
pkg/reconciler/intevents/topic/controller.go Do not exist 88.2%
pkg/reconciler/intevents/topic/resources/labels.go Do not exist 100.0%
pkg/reconciler/intevents/topic/resources/names.go Do not exist 66.7%
pkg/reconciler/intevents/topic/resources/publisher.go Do not exist 85.7%
pkg/reconciler/intevents/topic/topic.go Do not exist 69.6%

@Harwayne Harwayne changed the title 905 new reconcilers Reconcilers for PullSubscription and Topic in intevents May 11, 2020
@grantr
Copy link
Contributor

grantr commented May 11, 2020

Here's a gist showing the diff between the old and new reconciler directories: https://gist.github.com/grantr/222a54ee750fc86d9aeb8efbd2754f1f

Copy link
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 88f5a67 into google:master May 12, 2020
@Harwayne Harwayne deleted the 905-new-reconcilers branch May 12, 2020 00:10
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented May 12, 2020

@Harwayne: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-google-knative-gcp-go-coverage db5f6c5 link /test pull-google-knative-gcp-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved cla: yes (override cla status due to multiple authors bug) lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants