-
Notifications
You must be signed in to change notification settings - Fork 74
Reconcilers for PullSubscription and Topic in intevents #1013
Reconcilers for PullSubscription and Topic in intevents #1013
Conversation
This is being done because the intevents version will soon need the same functions and will be given the non-prefixed names (as they will continue to exist past the next release).
Here's a gist showing the diff between the old and new reconciler directories: https://gist.github.com/grantr/222a54ee750fc86d9aeb8efbd2754f1f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr, Harwayne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Harwayne: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Helps with #905
Proposed Changes
PullSubscription
andTopic
ininternal.events.cloud.google.com
to the Webhook.pkg/reconciler/pubsub
. The only changes are those needed by the compiler.Release Note